ImmersiveMC

ImmersiveMC

2M Downloads

Use Tags to Fix Lootr Crash

hammy275 opened this issue ยท 4 comments

commented

Note: Due to the move to the compatibility system, we need to handle the case of Lootr being "disabled" properly.

At the moment, we place in the null implementation, but this leaves Lootr things to go to normal containers (very bad)! Instead, we should replace it with a new implementation that allows us to bail early. More specifically, it needs to detect a Lootr container and tell our handlers to specifically not handle it despite it otherwise being a container.

commented

See https://discord.com/channels/524907814603456522/1266000591596028035/1274921390683983935 for handling moving items around both pre and post 1.21.

commented

The tag is lootr:containers from looking, just to have this written down somewhere.

To handle skipping Lootr containers when Lootr is disabled, in our handlers, if something is a Lootr container and we're using the null implementation, we declare that container as not handled by ImmersiveMC.

commented

Barring the part of this issue that's now in #439, this is done!