
Feedback and suggestions
jaypaw549 opened this issue ยท 2 comments
This mod has a lot of potential to become my go-to player revive mod. It appears to be more reliable than other revive mods I've worked with, and is a bit more flexible than most of them. I sadly haven't made a mod-pack that can really make use of it yet (I run First Aid a lot). However there's a lot of things in it that make me want to give it a run, and my next modpack likely won't include the First Aid mod (will have other health mechanics instead that should be compatible).
The things that make me want to run this mod
- Configurable amount of downs (I didn't even know I wanted this until I saw it)
- The options to configure debuffs when downed
- The options for how to recover or reset your downs
- Ability to allow some things to instantly kill you without going down
- The options for allowing players to self-revive with some items (I know it hooks the item use finish, so theoretically any item can be used to self-revive, not just foods), or by getting a kill
- It attempting to prevent the player's death rather than forcibly respawning the player in the same spot, but in a downed state (It matters a lot when there's effects that occur on death)
Things that I'd like to see included in it
- Additional options for customizing the effects you get when downed
- Options for effects when revived
- Options for the amount of health/food/saturation you revive with
- Ability to add/remove damage sources that instantly kill you (some sources will create infected versions of you when you take lethal damage, and it gets awkward when your own body is standing over you when you're still just downed)
- The ability to disable the give-up command/keybind (if keybind is implemented)
- Allow configuration changes to take effect without restarting the entire game (even if it's just through the in-game configuration menu)
- Some other things mentioned in other issues. (#12 and #13)
I am a programmer, and while I haven't really done much with forge/fabric mods, I can read and write code, so let me know if there's something I can do to help with any of this!
Hey there! Thank you for reaching out. Because of the influx of comments on it, I'll probably prioritize adding some of these things before continuing my work on rewriting immortuos.
I may go about a lot of these configuration options by making my own config engine which is gonna be strange.. namely just due to me knowing how my system for the horde manager works more than the modern landscape of existing config engines.
Once I do so all config changes but client side ones should apply with a command being ran.
As for the other issues, I also have ideas on how to make that work, though they may be intrusive compared to other options. I'll be sure to mark them as such though.
This update will still take a while, due to the scope of course.
As an update to this, I've gotten most of the basic stuff down on a local branch, and will probably finish the bulk of the update tonight. Maybe.
This is on my 1.20.4 branch, and due to me not necessarily having a clean 1.20.1 branch I don't particularly want to backport the changes. That said, first aid doesn't support anything above 1.20.1 yet. So first aid support won't be available until those versions align again.