Incorporeal 2 + Rhododendrite

Incorporeal 2 + Rhododendrite

135k Downloads

MatcherUtils uses reflection

quat1024 opened this issue ยท 2 comments

commented

Generally serializing and deserializing ICorporeaRequestMatchers is sorta messy and i should talk to botania people about this

commented

Is it fine if we just provide these three:

CorporeaHelper#getMatcherId(ICorporeaRequestMatcher matcher)
CorporeaHelper#getMatcherId(Class<? extends ICorporeaRequestMatcher> clazz)
CorporeaHelper#readMatcher(ResourceLocation id, CompoundNBT cmp)

Also your reflection is ugly as heck, you could just stick these maps into a static field and not repeat the reflective access more than once. Also static accessors work just fine. :wacko:

commented

fixed in 99c6607 to make it not use reflection & talked on discord and i guess it's good enough for now maybe look into a nicer api in 1.17