Incorporeal

Incorporeal

561k Downloads

[refactorin] Separate cyg actions and conditions from raw consumers/predicates

quat1024 opened this issue ยท 1 comments

commented

Currently I just toss around raw Predicate<ICygnusStack>s and whatever, this isn't very clean and these objects dont have a lot of metadata attached to them. I have to map lookup in the main registry every time i want to find the translation key of something ffs.

Messy areas of code include:

  • cycling the cyg cards
  • gui overlays
  • itemcygnuscard in general (btw, needs an Abstract prefix)
  • basically anything that deals with both kinds of cards gets pretty code-dupey

Does this mean I will need to put implementations in the api package, yeah, probably.

Also, would be very very nice to make them iforgeregistryentries so I get reg events for free and I can stop reinventing the wheel with simpleregistry anyways

commented

Done as a side effect of redoing the way I document these