Incorporeal

Incorporeal

561k Downloads

The modularization plan TODO list, don't open

quat1024 opened this issue ยท 0 comments

commented

I have not pushed this stuff because it mega breaks the build and I don't like doing that, and silly me forgot to make a branch, and I just don't like pushing heavily unfinished stuff anyways. Just a personal todo

  • Make sure the API is safe against features being disabled and responds in a useful way
  • Remove these classes and move their entries into dedicated feature classes:
    • IncorporeticBlocks
    • IncorporeticEntities
    • IncorporeticFluffBlocks/Items (merge into decorative blocks)
    • IncorporeticTiles
    • OldItemsClass
  • Event handlers:
    • pull them apart into dedicated module classes, if it makes sense (only 1 module using the event)
    • leave them in core/event if not
    • conditionally subscribe them based on the enabled features
  • Some miscellaneous junk I need to rehome:
    • IncorporeticFlowers (i think this can safely go in Corporetics)
    • IncorporeticLexicon (will need redoing with the module system)
    • The packet handler maybe?
    • Whatever depends on enumdyecolordataserializer
  • Sort out the big pile of etc classes, a lot of cygnus stuff snuck in there
  • TEST it
    • Data serializer shenanigans could happen again, watch out for that (make sure feature order is deterministic, I guess)
    • All sorts of enabled/disabled combinations
  • Source code pass to make sure no weird fully qualified names snuck in there