Industrial Foregoing

Industrial Foregoing

95M Downloads

[1.18.2] Mob Slaughter Factory ignores if it can actually damage a mob, causing issues with Luggage

GizmoTheMoonPig opened this issue ยท 0 comments

commented

(this is also an issue in 1.19, since the code for this hasnt changed between the versions)

Industrial Foregoing Version: 1.18.2-3.3.1.5-9

Titanium Version: 1.18.2-3.5.6-38

Hi, I have a small mod I work on called Luggage. (https://www.curseforge.com/minecraft/mc-mods/luggage) The mod adds an immortal pet that follows you around picking up items it finds and brings them to you. I recently had a user report that Mob Slaughter Factories can kill Luggage, which shouldn't happen. From looking at the code, it looks like you only check if the entity is alive before doing anything. I would recommend checking if the mob can also be hurt before doing anything to it, as this will probably be an issue with any mod that has an immortal mob that wanders near one of these things.

I'll change Luggage to drop all of its contained items if its somehow killed to prevent something like this in the future, but I thought I should also make you aware of this problem. Thanks for listening!