Industrial Foregoing

Industrial Foregoing

95M Downloads

[1.19] Mob Slaughter Factory & Minecolonies Exploit

TheDieselPunk opened this issue ยท 1 comments

commented

DO NOT REPORT AN ISSUE IF YOU HAVEN'T TESTED THE ISSUE WITH THE LATEST VERSION IN CURSEFORGE

Industrial Foregoing Version: industrial-foregoing-1.19.2-3.3.2.1-3

Titanium Version: titanium-1.19.2-3.7.0-23

Crashlog If Applicable (Upload to pastebin/gist):

The Mob Slaughter Factory appears to remove entities rather than killing them, I assume for performance reasons. Currently, the Mob Slaughter Factory will also process Minecolonies Colonists, which will respawn automatically within the colony after removal. This allows for free infinite Pink Slime and Liquid Meat, without having to set up any mob breeding systems.

commented

MFR used to implement this by applying damage (per operational tick) in a loop until the health of the entity was at zero:

https://github.com/skyboy/MineFactoryReloaded/blob/master/src/main/java/powercrystals/minefactoryreloaded/tile/machine/mobs/TileEntitySlaughterhouse.java#L66

Would simply be calling the kill method on the entity suffice here? Or would we also want to set the health to be zero before hand, just to be safe?

I'm happy to put in a PR for this provided I can get some clarification on the preferred option would be.