Industrial Foregoing

Industrial Foregoing

95M Downloads

[1.20.1] Skipping loading recipe as it's serializer returned null

jamieb999 opened this issue ยท 10 comments

commented

DO NOT REPORT AN ISSUE IF YOU HAVEN'T TESTED THE ISSUE WITH THE LATEST VERSION IN CURSEFORGE

Industrial Foregoing Version: industrial-foregoing-1.20.1-3.5.14

Titanium Version: titanium-1.20.1-3.8.25

Crashlog If Applicable (Upload to pastebin/gist):

https://pastebin.com/RuBycDH1

See the pastebin above for the full logs.

You keep getting an error like this there are several receipes that
are not loading

[12Jan.2024 23:12:42.379] [main/INFO] [net.minecraft.world.item.crafting.RecipeManager/]: Skipping loading recipe industrialforegoing:laser_drill_ore/ores/fluorite as it's serializer returned null

see the pastebin above. There are multiple recipes not loading it is
not just that one.

The server here is a forge 1.20.1 server
running forge-1.20.1-47.2.4-installer.jar

So why am I getting these info and why are the recipe's not loading?

I went on your discord server and I was on the industrial-foregoing channel
to get answers about this as well prior to opening this bug ticket to see if it
could be easily fixed but I got no answer on you discord server.
I believe this is a bug with the mod anyways and a ticket probably should be
opened here.

Can you please fix this issue.

Jamie (she / her)

commented

Full logs on startup are at https://pastebin.com/6AzqxX0H

oh and so you know if you start looking though the above logs and notice there were
some mods outdated and the server was back a version well I updated the server
to forge-1.20.1-47.2.19-installer.jar

and the problem still persists updating all the mods to the latest version and updating the
server did not fix this problem.

[13Jan.2024 01:03:17.696] [main/INFO] [net.minecraft.world.item.crafting.RecipeManager/]: Skipping loading recipe industrialforegoing:laser_drill_ore/ores/yellorite as it's serializer returned null

There are multiple recipies not loading the same as before

Now the logs for the new update to are located at
https://pastebin.com/MVy7Y1fP

The server is running on Debian 12

uname -a
Linux server2.removed.local 6.1.0-9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.27-1 (2023-05-08) x86_64 GNU/Linux

Java Version

java --version
openjdk 17.0.9 2023-10-17
OpenJDK Runtime Environment (build 17.0.9+9-Debian-1deb12u1)
OpenJDK 64-Bit Server VM (build 17.0.9+9-Debian-1deb12u1, mixed mode, sharing)

commented

Working as intended

commented

This it what it does. Are you a modder to know how it works?

commented

No it isn't working as intended.. it should load the recipes or if it doesn't see the correct mod pack
there then it should skip trying to load the item all together this is most definately not working as intended. This needs
to be fixed.

commented

I am a trained professional in the IT field and I know that this is sloppy. If it doesn't detect the mod needed to load that item
then it should not even try to load the issue. This needs to be fixed. This is not working properly and needs to be fixed. This issue is not fixed. reopen this ticket now.

commented

Nah, it's a forge thing, you literally have no idea how this works.

commented

Don't tell me that I don;t have any idea how it works because I do. Wow you are insulting. Are you the dev? because you have no clue how to properly code a mod. Fix this issue this matter is not resolved.

commented

I literally have public repos and millions of downloads, what do you have? Nothing.

Go cry somewhere else.

commented

Don't tell me that I don;t have any idea how it works because I do. Wow you are insulting. Are you the dev? because you have no clue how to properly code a mod. Fix this issue this matter is not resolved.

@jamieb999 Hello, I am too a dev. Please do not insult other devs. Your profession has no meaning here. This is coding for a Minecraft mod which has a lot of quirks and things to consider. If you do not mod, which it seems you are admitting to not be doing so, that means you do not understand this log entry at all despite claiming that you do. A lie.

The log entry is working as intended by Forge. Seriously. Right here in Forge's patch.
https://github.com/MinecraftForge/MinecraftForge/blob/88d2dc6c8f91fd3a6b38fa06bd92cde2db1c94db/patches/minecraft/net/minecraft/world/item/crafting/RecipeManager.java.patch#L35

The whole point is the custom recipe condition added by Forge (for Buuz135's and everyone else's use case of supporting inter-mod recipes) will return null if no condition matches (like the other mod not being on) which then Forge will explicitly log this recipe skipping with that log message you see.

The null comes from here. Which you can see returns null if none of the conditional recipe's conditions matches. An intended result by Forge.
https://github.com/MinecraftForge/MinecraftForge/blob/88d2dc6c8f91fd3a6b38fa06bd92cde2db1c94db/src/main/java/net/minecraftforge/common/crafting/ConditionalRecipe.java#L60

This was a conscious decision by Forge to log this at info level to the logs in 1.20.1.

commented

If I'm understanding Forge's code correctly, that Logger#info call should never be reached if the recipe's conditions aren't met, which makes me think that there is indeed an issue here.