Industrial Revolution

Industrial Revolution

Mods
5M Downloads

[BUG] Fisher uses power continuously

MrLavender opened this issue ยท 0 comments

commented

Description:

  • The fisher drains power continuously regardless of whether it has a rod to fish with or water to fish in.

Looking at the code this is very obvious, so I'm wondering whether it is intentional?

Industrial-Revolution/src/main/kotlin/me/steven/indrev/blockentities/farms/FisherBlockEntity.kt

Lines 47 to 49 in fb44c0e

override fun machineTick() {
val upgrades = getEnhancers()
if (!use(getEnergyCost())) return

Comparing to other machines their tick goes

  • canUse(energyCost) ?
  • check other requirements
  • do work
  • use(energyCost)

whereas the fisher is

  • use(energyCost) ?
  • check other requirements
  • do work

Steps to Reproduce:

  • Place a fisher anywhere and connect a power source.

Technical Information:

  • Minecraft: 1.16.5
  • Fabric API: 0.34.6+1.16
  • Industrial Revolution: 1.9.18
  • Modpack: custom