Industrial Revolution

Industrial Revolution

5M Downloads

Crash with item pipe [BUG]

renzhentaxi opened this issue ยท 1 comments

commented

Description:
Crash with pipe

Steps to Reproduce:

  • Steps to reproduce this behaviour

Technical Information:

  • Minecraft: 1.17
  • Fabric API: fabric: Fabric API 0.37.0+1.17
  • Industrial Revolution: Industrial Revolution 1.10.0-alpha.1
  • Modpack: All of Fabric

Logs:
https://pastebin.com/Pj9s8tRv
Details:

I think the issue is with the random mode

return Comparator.comparing { R.nextInt(3) - 1 }
.

Timsort requires that a > b and b > c then a > c but it looks like the comparator for random mode is returning -1,0,1 randomly everytime. Which means that sometimes it might cause the following to be true a>b b>c and c>a

Might also be the round robin mode bugging (maybe some types of race condition where the inventory got updated while the sorting was happening)

commented

Thanks for the detailed report, it made fixing it much easier :)