Industrial Revolution

Industrial Revolution

Mods
5M Downloads

[BUG]

lukaspupkalipinski opened this issue ยท 0 comments

commented

Description:
Materials from tech reborn are bugy. A Reforge is not possible. See Picture
image

getRepairIngredient() function for tin / copper /.. Tools and Armor returns a empty list. see log.
Not sure if this is a java - Kotin issue. You find the src in https://github.com/nvb-uy/Tierify/ ReforgeScreenHandler.java

Steps to Reproduce:

  • Use Reforge Gear Feature of Mod: tierify 1.2.0

Technical Information:

Details

[21:40:49] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.16.7
[21:40:49] [ForkJoinPool-1-worker-7/WARN]: Mod magna uses the version ${version} which isn't compatible with Loader's extended semantic version format (Could not parse version number component '${version}'!), SemVer is recommended for reliably evaluating dependencies and prioritizing newer version
[21:40:49] [main/INFO]: Loading 96 mods:
- cloth-config 11.1.136
-- cloth-basic-math 0.6.1
- fabric-api 0.92.2+1.20.1
|-- fabric-api-base 0.4.31+1802ada577
|-- fabric-api-lookup-api-v1 1.6.36+1802ada577
|-- fabric-biome-api-v1 13.0.13+1802ada577
|-- fabric-block-api-v1 1.0.11+1802ada577
|-- fabric-block-view-api-v2 1.0.1+1802ada577
|-- fabric-blockrenderlayer-v1 1.1.41+1802ada577
|-- fabric-client-tags-api-v1 1.1.2+1802ada577
|-- fabric-command-api-v1 1.2.34+f71b366f77
|-- fabric-command-api-v2 2.2.13+1802ada577
|-- fabric-commands-v0 0.2.51+df3654b377
|-- fabric-containers-v0 0.1.64+df3654b377
|-- fabric-content-registries-v0 4.0.11+1802ada577
|-- fabric-convention-tags-v1 1.5.5+1802ada577
|-- fabric-crash-report-info-v1 0.2.19+1802ada577
|-- fabric-data-attachment-api-v1 1.0.0+de0fd6d177
|-- fabric-data-generation-api-v1 12.3.4+1802ada577
|-- fabric-dimensions-v1 2.1.54+1802ada577
|-- fabric-entity-events-v1 1.6.0+1c78457f77
|-- fabric-events-interaction-v0 0.6.2+1802ada577
|-- fabric-events-lifecycle-v0 0.2.63+df3654b377
|-- fabric-game-rule-api-v1 1.0.40+1802ada577
|-- fabric-item-api-v1 2.1.28+1802ada577
|-- fabric-item-group-api-v1 4.0.12+1802ada577
|-- fabric-key-binding-api-v1 1.0.37+1802ada577
|-- fabric-keybindings-v0 0.2.35+df3654b377
|-- fabric-lifecycle-events-v1 2.2.22+1802ada577
|-- fabric-loot-api-v2 1.2.1+1802ada577
|-- fabric-loot-tables-v1 1.1.45+9e7660c677
|-- fabric-message-api-v1 5.1.9+1802ada577
|-- fabric-mining-level-api-v1 2.1.50+1802ada577
|-- fabric-model-loading-api-v1 1.0.3+1802ada577
|-- fabric-models-v0 0.4.2+9386d8a777
|-- fabric-networking-api-v1 1.3.11+1802ada577
|-- fabric-networking-v0 0.3.51+df3654b377
|-- fabric-object-builder-api-v1 11.1.3+1802ada577
|-- fabric-particles-v1 1.1.2+1802ada577
|-- fabric-recipe-api-v1 1.0.21+1802ada577
|-- fabric-registry-sync-v0 2.3.3+1802ada577
|-- fabric-renderer-api-v1 3.2.1+1802ada577
|-- fabric-renderer-indigo 1.5.2+85287f9f77
|-- fabric-renderer-registries-v1 3.2.46+df3654b377
|-- fabric-rendering-data-attachment-v1 0.3.37+92a0d36777
|-- fabric-rendering-fluids-v1 3.0.28+1802ada577
|-- fabric-rendering-v0 1.1.49+df3654b377
|-- fabric-rendering-v1 3.0.8+1802ada577
|-- fabric-resource-conditions-api-v1 2.3.8+1802ada577
|-- fabric-resource-loader-v0 0.11.10+1802ada577
|-- fabric-screen-api-v1 2.0.8+1802ada577
|-- fabric-screen-handler-api-v1 1.3.30+1802ada577
|-- fabric-sound-api-v1 1.0.13+1802ada577
|-- fabric-transfer-api-v1 3.3.5+8dd72ea377
-- fabric-transitive-access-wideners-v1 4.3.1+1802ada577
- fabric-language-kotlin 1.12.0+kotlin.2.0.10
|-- org_jetbrains_kotlin_kotlin-reflect 2.0.10
|-- org_jetbrains_kotlin_kotlin-stdlib 2.0.10
|-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 2.0.10
|-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 2.0.10
|-- org_jetbrains_kotlinx_atomicfu-jvm 0.25.0
|-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.8.1
|-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.8.1
|-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.6.0
|-- org_jetbrains_kotlinx_kotlinx-io-bytestring-jvm 0.5.1
|-- org_jetbrains_kotlinx_kotlinx-io-core-jvm 0.5.1
|-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.7.1
|-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.7.1
-- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.7.1
- fabricloader 0.16.7
-- mixinextras 0.4.1
- indrev 1.16.5-BETA
|-- libgui 8.1.1+1.20.1
| |-- jankson 6.0.0+j1.2.3
| | -- blue_endless_jankson 1.2.3
| -- libninepatch 1.2.0
|-- magna ${version}
| -- omega-config 1.0.8
|-- noindium 1.1.0+1.19
|-- patchouli 1.20.1-80-FABRIC
| -- fiber 0.23.0-2
|-- step-height-entity-attribute 1.2.0
-- team_reborn_energy 3.0.0
- java 17
- minecraft 1.20.1
- necronomicon 1.6.0
- reborncore 5.8.7
-- team_reborn_energy 3.0.0
- techreborn 5.8.7
-- team_reborn_energy 3.0.0
- tiered 1.2.0
|-- autotag 2.0.2+1.20
|-- autotag-convention 2.0.2+1.20
| -- autotag 2.0.2+1.20
|-- com_fasterxml_jackson_core_jackson-annotations 2.15.2
|-- com_fasterxml_jackson_core_jackson-core 2.15.2
|-- com_fasterxml_jackson_core_jackson-databind 2.15.2
|-- libz 1.0.2
-- reach-entity-attributes 2.4.0

Logs:
[21:41:45] [Server thread/INFO]: [STDOUT]: --------------------------
[21:41:45] [Server thread/INFO]: [STDOUT]: baseItem: 9 copper_ingot
true
[21:41:45] [Server thread/INFO]: [STDOUT]: tool:translation{key='item.indrev.copper_shovel', args=[]}
[21:41:45] [Server thread/INFO]: [STDOUT]: Mat :COPPER
[21:41:45] [Server thread/INFO]: [STDOUT]: Ingredient :[] // should be {"item":"copper_ingot"}
[21:41:45] [Server thread/INFO]: [STDOUT]: test :false

Details:

private void updateResult() {
        if (this.getSlot(0).hasStack() && this.getSlot(1).hasStack() && this.getSlot(2).hasStack()) {
            Item item = this.getSlot(1).getStack().getItem();
            if (ModifierUtils.getRandomAttributeIDFor(null, item, false) != null && !this.getSlot(1).getStack().isDamaged()) {

                List<Item> items = Tierify.REFORGE_DATA_LOADER.getReforgeBaseItems(item);
                ItemStack baseItem = this.getSlot(0).getStack();
                System.out.println("--------------------------");
                System.out.println("baseItem: "+baseItem);
                System.out.println(items.isEmpty());
                if (!items.isEmpty()) {
                    this.reforgeReady = items.stream().anyMatch(it -> it == baseItem.getItem());
                } else if (item instanceof ToolItem toolItem) {
                    
                    
                    System.out.println("tool:" + toolItem.asItem().getName());
                    System.out.println("Mat :"+toolItem.getMaterial());
                    System.out.println("Ingredient :"+toolItem.getMaterial().getRepairIngredient().toJson());
                    System.out.println("test :"+toolItem.getMaterial().getRepairIngredient().test(baseItem));
                    this.reforgeReady = toolItem.getMaterial().getRepairIngredient().test(baseItem);

Link: nvb-uy/Tierify#19