InfinityLib

InfinityLib

16M Downloads

Crash with Avatar Mod 2: Out of the Iceberg

FavouriteDragon opened this issue ยท 8 comments

commented

AgriCraft/AgriCraft#1205
Basically, it messes with an import.

commented

Is the mod Open Source?

commented

Yep!
It's getting rewritten, but the branch we're currently using is FD/OldPackets.
https://github.com/ProjectKorra/AvatarMod/tree/FD/OldPackets

commented

Strange, can it be that it is because InfinityLib ships joml as well?

InfinityLib/build.gradle

Lines 37 to 39 in c427fea

shade "org.joml:joml:1.9.2"
compile "org.joml:joml:1.9.2:javadoc"
compile "org.joml:joml:1.9.2:sources"

Perhaps try updating to the same version of joml?
https://github.com/ProjectKorra/AvatarMod/blob/FD/OldPackets/build.gradle#L44-L46

commented

The stacktrace displays this:
java.lang.NoSuchMethodError: org.joml.Vector4d.mul(Lorg/joml/Matrix4d;)Lorg/joml/Vector4d;

I have no idea what that 'L' is doing there...

commented

Ok I'll try doing that! I have 4 days off school coming up :P
Yeah I don't know why either ๐Ÿ˜‚

commented

Hey, the other developer of the Avatar mod here.

I have just resolved this issue on our side, by relocating the joml and snakeyaml packages to the com.crowsofwar.avatar.<module> package. I suggest you do this too to prevent further issues like this. Feel free to take a look at our build.gradle to see how I did it. I relocated them using the shadow plugin, which I really recommend. It is important to not forget to reobfuscate the shadowed jar. Again, see our build.gradle for an example on how to do that.

Cheers!

commented

Closing since I am moving to 1.16 where this is no longer relevant (I am no longer using joml).