The new configurationHandler of the core is not implemented
belug23 opened this issue ยท 6 comments
The configuration file of the core was changed in Lunatrius/LunatriusCore@9e54ff8 and "command/InGameInfoCommand.java" and "config/Config.java" are not up to date, impossible to compile this last version.
No more save() function :
https://github.com/Lunatrius/InGame-Info-XML/blob/master/src/main/java/com/github/lunatrius/ingameinfo/command/InGameInfoCommand.java#L81
No more load() function :
https://github.com/Lunatrius/InGame-Info-XML/blob/master/src/main/java/com/github/lunatrius/ingameinfo/config/Config.java#L38
I think those last two are not needed anymore, but this next one is out of my league for now :
/InGame-Info-XML/build/sources/java/com/github/lunatrius/ingameinfo/config/Config.java:31: error: cannot find symbol
Property property = get(Strings.CONFIG_CATEGORY_ALIGNMENT, alignment.toString().toLowerCase(), alignment.getXY(), String.format(Strings.CONFIG_ALIGNMENT_DESC, alignment.toString()));
symbol: method get(String,String,String,String)
location: class Config
But I think the loadProperties() is now out of date completly and I'm not sure to be able to follow the changes to adapt it to configurationHandler I know "get()"'s are now gone, but I don't understand they have been replaced by what?
I'm happy to see an opensource mod!
Thanks and continue your good work.
Don't worry I was aware that Master had chances to be broken I just wanted to document what I found while trying to implement it on my 1.7.10 mod pack..
Could you please give me some hints on where to look to help you. You could Open tickets for other parts that need refactoring to be 1.7.10 and tag them so I would not need to do trial and dig trough error one at a time.
Thanks.
Sorry for the double post, but what I understood was that you wanted your config to depend from bspkrs.util.config.Configuration so I've started and I added the bscore dependency into gradle but it seems that @bspkrs' ivy repository is broken (not files in the dropbox or closed account).
So how do you want to manage that? publishing a version of bscore into your own repository? or documenting a way to use it locally?
Thanks.
The core is for 1.7.10, which is why it doesn't work with IGI. I've been rewriting parts of my mods to use @bspkrs' configuration stuff, which made my own Configuration
/Config
implementation obsolete.
It's a rather bold move to break things just like that, but most of the mods don't work on 1.7.2 and 1.7.10 anyway. The latest commit was a mistake and if you want to compile for 1.7.2, checkout the 1.7.2
tag or a8c318a. I didn't have a lot of time after updating a few of my other mods and I'll be updating IGI, MSH and Schematica today/tomorrow.
While I'm at it, I'm refactoring around a few things, following LetsModReboot.
Fixed with e3d0dfb.