Inspirations

Inspirations

14M Downloads

BlockColors crash if another mod has an error

WenXin20 opened this issue ยท 6 comments

commented

Describe the bug:

  • If another mod has an error, such as with an invalid config file, Inspirations will crash instead of displaying the forge error screen and what went wrong with the other mod.
  • This could mislead the player into thinking Inspirations is at fault instead of something else.

Versions:

  • Minecraft: v1.14.4
  • Forge: v28.1.109
  • Mantle: v1.4.32
  • Inspirations: v1.0.2

Attachments

Crash Report

commented

Yeah, this is a Forge bug, see MinecraftForge/MinecraftForge#5862. There is not a ton I can do about it as if its not block colors that crashes, its going to be something else later.

I suppose I can add null checks like I had in 1.12, but that will just bounce the issue to the next mod registering block colors, or perhaps the Forge event following block colors.

commented

Adding null checks would be nice, it took me pretty much all day to figure out which mod was actually crashing. I had to remove all the mods that were giving me blockColor crashes.

commented

Whenever you see a block colors crash, your best bet right now is the full game logs. Normally the actual exception is logged before block colors crashes.

commented

That's what I checked first, but unfortunately, it was a crash between 2 other mods, but the logs only pointed to one of those mods. It all figured out now though.

commented

Mostly caught, whats not caught Forge has dealt with, so closing

commented

Latest Forge issue is MinecraftForge/MinecraftForge#6374 for my reference