Integrated Crafting

Integrated Crafting

37M Downloads

Using a reusable item, breaks crafting queues when it's not the last step

wolfsilver00 opened this issue ยท 8 comments

commented

Issue type:

  • ๐Ÿ› Bug

Short description:

As an example of a queue:

Image

Image

Hammer turns raw ores into dust, dust goes to furnace to become an ingot. Both recipes work correctly by themselves (Considering my last issue, without tag option).
When the step that requires a reusable item goes first, the queue stops after one iteration.
When you do otherwise (reusable item as the last step) it seems to work correctly

Steps to reproduce the problem:

  1. Design a recipe that uses an item and creates a dependency on another recipe, which uses a reusable item
  2. launch it

Expected behaviour:

Step should complete as it does even if its not preceded by another one


Versions:

  • This mod: 1.1.13
  • Minecraft: 1.21.1
  • Mod loader version: Neoforge 113

Log file:

commented

Thanks for reporting!

commented

Nope, im starting one job, that has the other as a dependency. Uploading some video

Screencast_20250210_115630.webm

If I were to create this the other way around (for example, putting a recipe for dust, using a machine to transform ores into raw materials, and those raw materials into dust using the hammer (reusable) as the last step), it works without issue.

Of course what Ive shown in the video fails in other circumstances, for example a craft order for something that requires multiple ingots and goes through the process of generating a consumable with a reusable item on any of its steps, except the last.

commented

Soirry, recording was trash, here is some more detail on how the thing runs

Screencast_20250210_121325.mp4
commented

In your first video, is the problem of the job stalling just not that your hammer is broken?
I noticed that your hammer had ~100 uses left, and the job seems to have halted after crafting ~100 dusts.

commented
commented

I expect hammers to be used up

That should happen indeed.

I'll have a look if I can reproduce this in my dev environment in the near future.

Note to self: try this out by starting from my test shears recipe combined with an undead sapling recipe to something else. And request a large number of crafts.

commented

When the step that requires a reusable item goes first, the queue stops after one iteration.
When you do otherwise (reusable item as the last step) it seems to work correctly

If I understand correctly, you are starting these jobs manually after each other.
If so, then you are running into a known limitation (#112) for which no solution has been implemented yet.
(This is not related to the reusability of items)

Please let me know if I misunderstood, and I'll re-open this issue.
In that case, could you share additional details to help me understand this issue (e.g. a video)?

commented

I spent quite a bit of time attempting to reproduce the problem in a controlled environment, but I was unsuccessful unfortunately.

@wolfsilver00 Could you share some more details, or attempt to reproduce this in a minimal world with a minimal set of mods?