Issue type:

• 🐛 Bug

Short description:

Randomly decided to hard crash (immediate server stopped) when I went to autocraft a certain item (which I have autocrafted before no problem) Now when I restart and open my storage system (after refreshing it as it doesnt initially load) it immediately crashes upon interaction, likely due to the recipe trying to craft again

Edit: Canceled the crafting through crafting job terminal and it was fine, tried again and crashed
Edit: Broke and replaced the crafting interface and remade the 2 related(?) recipe variables (see below), no change

Steps to reproduce the problem:

Unknown, though it is repeatable in this world (server)!

Expected behaviour:

No crash

Versions:

• Minecraft: 1.20.1
• Mod loader version: Forge 47.4.0

Log file:

crash-2025-07-25_02.32.42-server.txt
crash-2025-07-25_02.52.33-server.txt
crash-2025-07-25_04.01.36-server.txt

Additional recipe context

basic chem tank for rotary condensentrator


Note it also crashed when trying to craft 1, not 2

Thanks for reporting!

That's very weird.
This crash should be caught here: https://github.com/CyclopsMC/IntegratedCrafting/blob/master-1.21-lts/src/main/java/org/cyclops/integratedcrafting/core/crafting/processoverride/CraftingProcessOverrideCraftingTable.java#L61-L64

Can you try without this SINYTRA CONNECTOR mod installed? It's possible they are breaking exception handling somehow.

GitHub

IntegratedCrafting/src/main/java/org/cyclops/integratedcrafting/core/crafting/processoverride/CraftingProcessOverrideCraftingTable.java at master-1.21-lts · CyclopsMC/IntegratedCrafting

Craft stuff in Integrated Dynamics networks. Contribute to CyclopsMC/IntegratedCrafting development by creating an account on GitHub.

I see what you mean there, unless somewhere else is triggering it, that would make sense to catch it
I do know this same recipe has worked in the past for me on my server with out too much having changed since, which is weird that it now has an issue

Unfortunately I can't try without Sinytra as I'm unable to reproduce the issue in my singleplayer test world and I can't exactly remove a mod on the server without potential corruption/loss of stuff

You could try it in a copy of your world & server though, if corruption is a threat.
Obviously since Sinytra is a connector, once you remove it (in the copy) you should also remove everything that has it as a dependency.

That was quite difficult, but I managed to download my server's world (it was burried in permissions plus >50GB) and confirm the crash is still present in singleplayer with this world and when Syntra "Connector" is disabled

crash-2025-07-26_01.31.08-server.txt

Thanks for checking @RoarkCats.

I would recommend removing some mods step by step (e.g. through binary search) to see until when the starts/stops occurring.

Unfortunately that won't work in this scenario, I'm used to doing binary searches to test this stuff, but seeing as how it's world specific and I've got about 350 mods, I'm not even able to load into the world with one half of the binary search, and the other half is crashing without a crash report. Even if I could get it working I would likely have to reset the world repeatedly which isn't so easy with the world size, and I've tried removing a fair bit of the files which may not be relevant such as extra region files but that seems to break something or other in the world preventing it from loading. (TDLR; won't work)

If you have any specific mods you suspect based on the crash logs or modlist, I can try testing without those. This is our modpack

I think I might know what's causing it actually

this is the recipe

I have this in my system

when I use any of the 5 fresh empty tanks or 2 used empty tanks (with nbt) there's no issue

but the recipe becomes invalid seemingly if I use the one with fluid in it picture above

my guess would be that Integrated Crafting is failing to realize what should be a valid recipe is actually invalid for this specific sub-case and isn't catching that in time or something thus crashing

Note: does work fine using both types when I take the filled one out of the system

@RoarkCats Could you try if you could reproduce this crash with just the ID mods + the mod adding this recipe (Mekanism?)?

Yes, reproduced with just ID mods & Mekanism

note: depends on what specifically is in the tank, if it can normally go in its fine

yet

crash-2025-07-27_13.35.37-server.txt

Perhaps when making the crafting plan or doing the crafting you have to re-verify that the ingredients do still work

Thanks for checking. I should be able to reproduce this in my dev environment.

Silly me, it looks like this was already fixed in 1.21, but not backported properly...