Issue type:

• 🐌 Performance issue

Short description:

Hello,
Since we updated to the latest version of FTB Skies, we have been hit with a memory leak issue. I took a heapdump and analyzed it and came up with org.cyclops.integrateddynamics.core.blockentity.BlockEntityMultipartTicking spawning hundreds of thousands of objects.

Steps to reproduce the problem:

Not 100% how to reproduce this for you but I believe the issue started with when FTB Skies updated to 1.2.1 and IntegratedDynamics updated to 1.19.2-1.16.5

If you need any additional information, please let me know and I will be happy to provide it.

Versions:

• This mod: IntegratedDynamics-1.19.2-1.16.5.jar
• Minecraft: 1.19.2
• Forge: forge-1.19.2-43.2.11

Profiler output:

Not sure what more I can give you but maybe this helps?

FYI, the only thing that changed in that update is this: 7f95ea7
And since that change seems unrelated, I think the issue is coming from somewhere else.
But feel free to downgrade to an earlier version, if you want to be sure.

Could you try turning on ID's network diagnostics? Perhaps there are some (new) parts that are causing issues.

It may be possible that your world just has a lot of cables?

Thanks for reporting!

I just wanted to add this to the report to help narrow down the issue.

Could you share your profiling log as explained in https://github.com/CyclopsMC/CyclopsCore/blob/master-1.18/.github/CONTRIBUTING.md#performance-issues-snail ?

GitHub

CyclopsCore/CONTRIBUTING.md at master-1.18 · CyclopsMC/CyclopsCore

Minecraft library mod for EvilCraft, Integrated Dynamics and others. - CyclopsCore/CONTRIBUTING.md at master-1.18 · CyclopsMC/CyclopsCore

Could you share your profiling log as explained in https://github.com/CyclopsMC/CyclopsCore/blob/master-1.18/.github/CONTRIBUTING.md#performance-issues-snail ?

GitHub**CyclopsCore/CONTRIBUTING.md at master-1.18 · CyclopsMC/CyclopsCore**Minecraft library mod for EvilCraft, Integrated Dynamics and others. - CyclopsCore/CONTRIBUTING.md at master-1.18 · CyclopsMC/CyclopsCore

Yes, I ran a spark heap summary here. https://spark.lucko.me/cmHrDu9ZQ9 or https://spark.lucko.me/cthU8vcsGH

@Aiidoneus Could you try comparing versions 1.15.2, 1.16.0, 1.16.1, to see from which one the problem occurs on your end?

I will try comparing if these version make a difference. I can tell you that the issue became apparent when we updated the server's modpack version from 1.1.0 to 1.2.0

This pack update include mod update for IntegratedDynamics from 1.19.2-1.16.4 to 1.19.2-1.16.5

I will see if I can reproduce on the versions you mentioned above though. It might take me a day or two to get it to reproduce properly on these versions.

Ah, but if the version increment was on those versions, then the versions I mentioned will probably unrelated. Will reply once I had time to look at this more closely.

OK. Let me see if I can narrow this down. No promises but I will do my best to rip this apart.