Integrated Dynamics

Integrated Dynamics

Mods
63M Downloads

Removing/Adding cables/variables/parts causes big client lag spikes

WhitePhant0m opened this issue · 3 comments

commented

Issue type:

  • 🐌 Performance issue

Short description:

Whenever a cable/part/variable is added/removed, it lags nearby clients for a sec.

Steps to reproduce the problem:

All I can say about reproduction steps is that only way I've been able to replicate is with another players setup, I've not been able to replicate this in the same server on my own, nor have I been able to replicate this in a minimal enviroment with only the involved mods.

I did manage to find out that it's the section with the HNN machines that causes lag whenever somethig is changed. But even when I try to replicate the setup(though somewhat minimally), I don't get the lag spikes, or at least I can't spot them.

Versions:

  • This mod: 1.23.5
  • Minecraft: 1.21.1
  • NeoForge: 21.1.58

Profiler output:

https://spark.lucko.me/fXd4TqtYZq
{DDDCA8D8-6B55-49C5-97C0-64852AFD1B6C}

image
image
image

commented

I can't find that setting in the neoforge configs, and I don't have anything set in my environment variables on my launcher,
and fairly sure it's the same for the other player, as I doubt they have changed pretty much any of the defaults.

commented

Thanks for reporting!

commented

From the profiler output, it looks like the overhead is be caused by the logger being set at trace-level (while it's usually at info-level or so).
This can definitely explain lag spikes, and would probably also slow down other parts of the game.
Trace level is usually only used in dev environments, or when attempting to debug something.

Could you check what your log level is?
This can probably be configured in your neoforge config or as an environment variable.

This would also explain why this can't be reproduced in another environment, as the logger level would be set to the default there.