Issue type:

• 🐌 Performance issue

Short description:

Was noticing some lag in my game, so I took some Spark profiles. Both mostly pointed towards IntDyn so I wanted to share them in hopes that there might be something to be done to improve performance. After the first one I ran some network diagnostics and found two aspects that were not working.

First Profile: https://spark.lucko.me/fO9jf7CetA

1. Item export - this was a simple "Export Item" aspect which should have had no issue. My network had stock but wasn't pulling the item properly and had a high Ticktime in network diagnostics. Eventually, I broke and replaced it and it seems to have fixed the high Ticktime.
2. Crating Writer - this was an old writer that had logic build around that was supposed to craft items once a threshold was passed. But my network had changed and I no longer had those crafting recipeis anymore. I ended up removing the crafting writer since I didn't need it anymore.

I then ran another profile.

Second Profile: https://spark.lucko.me/zlpvnleX1n

Which is better than the first, but still not the greatest. My network which was primarily used for everything (crafting and storage) is now mostly used for logistics, brining stuff in/out of the network. So besides it being a large/high item count network, it shouldn't be a doing a lot of active stuff.

Steps to reproduce the problem:

I'm not sure as I think it's associated to being a large/high item count network.

Versions:

• This mod: 1.25.1
• Minecraft: 1.21.1
• Neoforge: 21.1.92
• Modpack: ATM 2.21

Profiler output:

See above.

Thanks for reporting!

Relevant part of the first log:

Note to self: check if we're still using the right indexes for Export Item.

Relevant part of the second log:

This seems to be pointing to Sophisticated Storage, so not sure yet if there's something I could do about that on my end.

Thanks for looking into this. For the second log, do you think this is something I should raise up to the Sophisticated Storage team?

For the second log, do you think this is something I should raise up to the Sophisticated Storage team?

I'll look into it myself first. But it may be needed later.

Sounds good, just let me know if it gets to that point and you want be to reach out to them. Thanks.

I've finally added an issue on their GH. Hopefully something can come of it.

Or lowering your exporter's tick rate would also help of course.

@rhullah I just looked into this a bit. Here are my findings:

I'm not sure about the first log, especially since breaking/replacing it fixed the issue.
If it would recur in the future, I definitely want to learn more about the details of that part of the network.

For the second log, I think we're running into the limits here of ID accessing third-party storage systems via the regular item handler API.
The only solution I see here is for Sophisticated Storage to implement the Common Capabilities slotless item handler API (and probably also the inventory state API). Feel free to point them to this issue in case they are interested in implementing this.
Alternatively, switching to a mod that already implements that API (Colossal Chests) could also solve the issue.

An Integrated Storage addon has been on my todo list for a long time now for reasons like these...

Buuz135/FunctionalStorage#392

Thanks @DADA30000!