Integrated Dynamics

Integrated Dynamics

88M Downloads

Display Panel lighting being inconsistent and affected by the type of block above them

CrysMia opened this issue ยท 6 comments

commented

Issue type:

  • ๐Ÿ› Bug

Short description:

The lighting of Display Panels in facades is affected by the type of block being placed above them. Seemingly any block that does not let light through will cause them to go so dark that they're effectively not readable anymore. Reloading the area restores the proper lighting but any update to blocks or lighting around them will make them go dark again.

I am attaching an image of a test setup:

Image

Steps to reproduce the problem:

  1. Cover a display panel with a facade
  2. Place any block above the facade that is preventing light from passing through
  3. The Display Panel will go dark

Expected behaviour:

The Display Panel should retain it's lighting and stay readable.


Versions:

  • This mod: 1.27.5-1263
  • Minecraft: 1.21.1
  • Mod loader version: NeoForge 21.1.186

Log file:

Log doesn't show anything it seems, still providing it just to be safe: https://pastebin.com/n4sJiptX

commented

Thanks for reporting!

commented

Did you try without any other mods installed?

commented

Only Integrated Dynamics installed as well as it's dependencies. Had the issue first in a custom made modpack and couldn't find any issue regarding that so I wanted to make sure that it wasn't an incompatibility inside the modpack itself. Therefor I ended up with a new NeoForge instance in which only Integrated Dynamics, Cyclops Core and Common Capabilities are installed.

commented

Ok, thanks for checking!

commented

Been testing a bit more around with this issue. It seems that Display Panels are the most suspectible object for the underlying issue. It seems to be directly caused by facades and how they update the lighting on their respective block position, resulting in the following screenshot:
Image
Screenshot was taken within previously mentioned custom modpack tho, so unfortunately the exact same behaviour cannot be reproduced with only Integrated Dynamics installed. Haven't been able to locate the mod that makes the lighting issue appear that way but it seems to boil it down to facades directly while the Display Panel is just a symptom due to how lighting is updated with facades. Overall it seems to be in line with the behaviour that I have observed with the previous testing instance in which only Integrated Dynamics and it's dependencies were installed.

I tried another facade mod (Cable Facades) to cover Integrated Dynamics logic cables and was not able to reproduce the issue with these covers, even tho they're not made to fully work with ID cables. But I think it's safe to say that the issue is with the facades and how lighting is handled.

Hope this helps tracking that one down. If needed I can compile a list of mods that are used in the pack.

commented

I can confirm the lighting behaviour. Once a solid or translucent block gets placed on top, the display goes dark.
It also happens once the above blockspace is refilled by a piston push (but resets once retracted).

Regarding block/redstone updates. I tested whether I could re-trigger the issue after it has happened by updating the block or the one above. It looks like almost everything I tried is "safe" from re-triggering the issue;

  • Trigger the issue by placing an observer above the facaded display with its signal pointing into it
  • Reload the area (from world login or dimension travel) - this fixes the rendering
  • Attempt to retrigger the dark rendering by adding another block on top of the observer (causing redstone signal)
  • Normal rendering remains

But not if you do this instead:

  • Trigger the issue by placing a target block on top of the facaded display
  • Reload the area, temporarily fixes issue
  • Place another target block next to the previous
  • Rendering immediately goes dark once again (for both facaded displays under both target blocks, not just the one placed last)

So I think it may be affected by block- or redstone updates, but not always. This might be due to recent redstone update fixes made by mojang in some version.