Integrated Dynamics

Integrated Dynamics

Mods
63M Downloads

Menril trees do not spawn in any biome when Meneglin biome is disabled

CplPibald opened this issue ยท 1 comments

commented

Using Integrated Dynamics 0.7.2 on MC 1.11.2

To repro: Start a new world with the following configs:

biome {
   B:biome_meneglin=false
}
worldgeneration {
  I:general.wildMenrilTreeChance=2
}

Expected: Menril trees spawn often in forest biomes
Observed: No menril trees anywhere.

Analysis:

Disabling the biome in the config causes the registration to be skipped for the biome. Note the following line in fml-client-latest.log logged by ConfigurableTypeAction.commonRun() in CyclopsCore.

[Integrated Dynamics/integrateddynamics]: Skipped registering biome_meneglin

Skipping the registration means the BiomeMeneglin class is not constructed, and in particular is not added to the MinecraftForge.TERRAIN_GEN_BUS and therefore the class does not receive the DecorateBiomeEvent.Decorate events necessary to spawn trees.

commented

Ah, I should indeed move that decorate even listener outside of that class.