Integrated Dynamics

Integrated Dynamics

63M Downloads

Game fails to register any new advancements towards rewards after opening the guide for the first time

moonheart08 opened this issue Β· 66 comments

commented

Issue type:

  • πŸ› Bug

Short description:

I am unable to obtain rewards due to having viewed the book. The book doesn't update what Advancements i have, and as such never unlocks them.

Expected behaviour:

Book updates when i get a new advancement

Actual behaviour:

Book is the same as when i first crafted it, with only the first 2 advancements registered

Steps to reproduce the problem:

  1. Preform a few advancements, but dont trigger rewards
  2. Craft a book
  3. Realize you can no longer get rewards

Versions:

  • This mod: 0.9.6
  • CyclopsCore: 0.10.23
  • Minecraft: 1.12.2
  • Forge: 14.23.0.2531
commented

also had this issue, in the direwolf 20 1.12 pack v 1.1

advancements are only recognised by the book on the first time the pack is loaded, saving and reloading the game in the same instance doesnt trigger them, a full shutdown and reload of the pack is required.

Cyclops Core 0.10.23
Integrated Dynamics 0.9.6
Forge 14.23.0.2531

commented

I can't reproduce this myself in either single or multiplayer (in a clean environment).
So either some mod in the pack is causing the issue, or your server is somehow blocking some packets.

Are you playing on a server? If so, can you try in singleplayer? Do you see anything starting with "Received an invalid advancement" in the server logs?

commented

@moonheart08 @Morelyn Any information you can given me? Closing this one otherwise.

commented

I'll attempt to reproduce it when i get home. It's happened to me on all servers.

commented

Same Problem. I'm playing single player (custom modpack). I got nothing but the advancement in the console:

[23:03:18] [Server thread/INFO]: <PROFILE NAME> has made the advancement [Networks, for logic]
[23:03:18] [main/INFO]: [CHAT] <PROFILE NAME> has made the advancement [Networks, for logic]
commented

@fiws Would you be willing to try this in a clean environment (just ID and dependencies installed)? If that works, could you try adding the mods from your custom pack until you find one that breaks the advancement syncing?

commented

@rubensworks Thanks for the support.

It seems to be mod related as you expected. Only ID did work fine.
Testing is quite cumbersome, so I only tested a few more combinations. I could not reproduce it so far.

commented

@fiws binary search may help you out with finding the mod that breaks it.

commented

@rubensworks I actually also thought about that 😁 but its binary search with dependencies :\

Oh, I also noticed that Advancements are not linked to the world (but achievements are). So all Advancements that I already made are still there when I generate a new world. Is that how it should work?

commented

Playing Direwolf20 pack for 1.12.2, version 1.4.0
Single player world, having the exact same problem as described in the original post.

Advancements menu shows that I have unlocked stuff, but the book doesn't. I even have the stuff listed in chat, but the book just doesn't notice.

commented

So all Advancements that I already made are still there when I generate a new world.

@fiws Should not be able to happen, but probably the same cause as this issue here.

commented

Suddenly I can not reproduce this anymore with my modpack with newly generated worlds. But it's still happening using my old world.

commented

@Rixxaw So you correctly obtain the advancement in Minecraft, but it doesn't get recognised in the book?

Are you seeing anything in the console? What happens if you restart the world/game?

(This issue is still open btw, still haven't managed to reproduce it...)

commented

I see you have closed it. I'm playing single player DW 20 pack, and ran into something similar. I started with the book, so I didn't have the issue of nothing working afterwards. It seems however that any achievement that is tied to placing something into a Display is now not working. I jumped ahead at the start and made a few displays and such. Anyway I have a theory that it is tied to the Display panel's ID number. Once the display panel gets to a high ID number it doesn't trigger achievements anymore? Anyway I can't seem to get It to recognize Redstone Observement, and now it won't recognize Constant Definition and Arithmetic Addition. Even though I have the Variable store the variable in there and the math result showing on an attached display.

Seems like a fun mod, and the achievements will really bring in the technical players, for free loot πŸ‘ However it is an unfortunate stumbling block that either the text in the book is not describing the procedure correctly or its bugged, and thus I bring it up (not nit picking, as an important intro step to the mod that is not functioning) Screenshot

commented

This issue looks like one of those magic issues. I feel for you @rubensworks
I'll spend some free time looking into how the book works to potentially spot an issue.

commented

If anyone here is up for it, I could look into resolving this issue in the same way as #422. Which would require me to send dev builds that logs some debug information. (I hate this method of debugging, but there are not a lot of alternatives when I can not reproduce it myself)

commented

I'm all for giving something a go... I thought maybe I did something out of order to trigger it... I removed all the cables and rebuilt the achievement several times. I did restart the game and it didn't change anything... Its definately not working in my world, I could put that up for download maybe ...
Um Would it being an Akashic Tome matter?

commented

I assume you get the advancement in Minecraft, so it's not a problem with the network, but with how the server sends the advancement status to the client.

I'll send you a dev build soon (Friday or this weekend).

commented

I installed ID for the first time last night into an existing world and encountered the exact same problem @Rixxaw describes, involving the same advancements. Tried restarting, with no effect. I didn't know to check the Minecraft advancement list, but I suspect it registered there.

commented

Some of the achievements I didn't get in Minecraft so that could be my issue. For example I got the 10 Cables makes a network achievement can't remember name, and the book didn't notice it... But the book did notice the rest of the achievements on that page... Okay wait a second I just re-opened minecraft this morning and I now have the reward available... Could it being an Akashic Tome and Me turning the tome off / on have triggered it to fix the issue?

commented

Anyone else reporting anything here, please clarify if you get the Vanilla advancement notification or not. If you don't get the Vanilla advancement notification, then this is an issue different than this one, and please open a different issue in that case.

commented

@Rixxaw (completely) restarting the game will update the book. @Morelyn already reported that. I noticed the same behaviour.

commented

Yeah I restarted last night, but I doubt myself now that I checked every achievement. I was focused on the one achievement I'm stuck on.. The Math Int One... So I'm sorry.

commented

@rubensworks I'll let you know about the Vanilla advancement when I get home from work.
@Rixxaw FWIW I do not have Akashic Tome installed, and restarting didn't help.

commented

I'm going to test the Math int one Again this morning to see if there is some sort of link between these two just for my own sanity.

commented

I did not get the Redstone Observement advancement in the Minecraft advancements window.
I also just created a new instance of 1.12.2, installing only ID, IT, and both dependencies.

I worked my way through the book tutorials and got every advancement until I took the integer variable card out of the redstone reader and put it in the display panel: no Redstone Observement advancement.

I then took the variable card out of the display panel and put it in the redstone writer: got the Redstone Transmission advancement.

commented

Ok, for anyone here encountering this issue (unlocking advancements, but they are not syncing with the book), could you use the following CyclopsCore dev build, perform the following actions, and send me the logs? (Preferably in SSP, if not possible, also send me the server logs)

https://www.dropbox.com/s/78g4tvb9i9tu4o7/CyclopsCore-1.12.2-0.11.1-DEV.jar?dl=0

  1. Start the game (possibly a clean world)
  2. Open the book and close it again
  3. Achieve an ID advancement
  4. Open the book and go to the page where the advancement is shown (and is not being unlocked) and wait for at least 5 seconds.
  5. Close the game, and send me the full Forge log.

Thanks in advance!

(Note: make a backup before using this build in an existing world, and don't using it in actual gameplay as it may slow down your game)

Dropbox
Shared with Dropbox
commented

@rubensworks Thanks, here's the log file:
latest.zip

The first advancement that failed to unlock was Redstone Observement so that's where I stopped. I skimmed through the file and this looked relevant:

[00:23:31] [Netty Server IO #1/INFO]: [org.cyclops.cyclopscore.network.packet.SendPlayerAdvancementUnlockedPacket::32]: Send adv unlocked packet from server to client integrateddynamics:aspects/redstone_observement false

commented

@NerdimusPrime As mentioned before, you are not getting the vanilla advancement notification for that specific advancement (all other advancements work fine), so something else goes wrong (#500). This issue here is not occuring for you.

commented

Right, sorry.

commented

@moonheart08, @fiws, @Nightcaste, @Morelyn Any one willing to help debug this one? (See a few comments above)

commented

@rubensworks I will test it with my existing world (as I don't know how to reproduce it in a new one) when I have time.

commented

Sure. I'll swap out the dev jar in the pack i play when i get home, and post logs if i reproduce it. This may be a heisenbug, however.

commented

I hate this bug.

I loaded my old map and gained a new achievement but of course it worked this time. Could not get any variable card ones, but I guess that's another bug.
I'll see if I can try some things to reproduce it on the weekend.

Anyway … Even though it worked fine I got these errors from the logs, not sure if its "normal":

Log Snippet
[20:01:22] [Server thread/INFO]: <PROFILE NAME>[local:E:b6227e03] logged in with entity id 234 at (-347.4709673027495, 72.0, 527.7011306030711)
[20:01:22] [Server thread/INFO]: <PROFILE NAME> joined the game
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: java.lang.NullPointerException
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.ByteBufUtils.writeUTF8String(ByteBufUtils.java:165)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.ExtendedBuffer.writeString(ExtendedBuffer.java:23)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec$1.encode(PacketCodec.java:29)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec$8.encode(PacketCodec.java:150)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.lambda$encode$0(PacketCodec.java:363)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.loopCodecFields(PacketCodec.java:346)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.encode(PacketCodec.java:356)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketBase.toBytes(PacketBase.java:58)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:30)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:26)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.FMLIndexedMessageToMessageCodec.encode(FMLIndexedMessageToMessageCodec.java:71)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageCodec$1.encode(MessageToMessageCodec.java:67)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:88)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageCodec.write(MessageToMessageCodec.java:116)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:738)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:801)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:814)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:794)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:831)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1032)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:296)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper.sendTo(SimpleNetworkWrapper.java:249)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketHandler.sendToPlayer(PacketHandler.java:78)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.integrateddynamics.core.persist.world.LabelsWorldStorage.onPlayerLoggedIn(LabelsWorldStorage.java:110)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_162_LabelsWorldStorage_onPlayerLoggedIn_PlayerLoggedInEvent.invoke(.dynamic)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.FMLCommonHandler.firePlayerLoggedIn(FMLCommonHandler.java:573)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.server.management.PlayerList.initializeConnectionToPlayer(PlayerList.java:218)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:256)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.access$100(NetworkDispatcher.java:72)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:205)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:179)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:788)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:666)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:239)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
[20:01:22] [Server thread/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at java.lang.Thread.run(Thread.java:748)
[20:01:22] [Server thread/INFO] [mcjty.lib.varia.Logging]: SMP: Player logged in: Sync diminfo to clients
[20:01:22] [Server thread/INFO] [mcjty.lib.varia.Logging]: Send dimlet rules to the client
[20:01:22] [Server thread/INFO] [mcjty.lib.varia.Logging]: Rules packet size: 5785 of 8192
[20:01:22] [Server thread/INFO] [Actually Additions]: Successfully loaded WorldData!
[20:01:22] [Server thread/INFO] [Actually Additions]: Sending Player Data to player <PROFILE NAME> with UUID 0e411915-5284-427a-a006-af97a20d61cd.
[20:01:22] [Server thread/INFO] [Astral Sorcery]: [AstralSorcery] Synchronizing configuration to <PROFILE NAME>
[20:01:25] [ForkJoinPool-1-worker-11/INFO] [opencomputers]: Starting OpenComputers version check.
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: java.lang.IndexOutOfBoundsException: readerIndex(110) + length(1) exceeds writerIndex(110): UnpooledSlicedByteBuf(ridx: 110, widx: 110, cap: 110/110, unwrapped: UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 0, widx: 111, cap: 256))
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1396)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.buffer.AbstractByteBuf.readByte(AbstractByteBuf.java:687)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.network.PacketBuffer.readByte(PacketBuffer.java:864)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.ByteBufUtils.readVarInt(ByteBufUtils.java:79)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.ByteBufUtils.readUTF8String(ByteBufUtils.java:151)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.ExtendedBuffer.readString(ExtendedBuffer.java:18)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec$1.decode(PacketCodec.java:34)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec$8.decode(PacketCodec.java:167)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.lambda$decode$1(PacketCodec.java:370)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.loopCodecFields(PacketCodec.java:346)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketCodec.decode(PacketCodec.java:369)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at org.cyclops.cyclopscore.network.PacketBase.fromBytes(PacketBase.java:53)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.decodeInto(SimpleIndexedCodec.java:36)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.simpleimpl.SimpleIndexedCodec.decodeInto(SimpleIndexedCodec.java:26)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.FMLIndexedMessageToMessageCodec.decode(FMLIndexedMessageToMessageCodec.java:101)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.FMLIndexedMessageToMessageCodec.decode(FMLIndexedMessageToMessageCodec.java:38)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageCodec$2.decode(MessageToMessageCodec.java:81)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:274)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:99)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:147)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraft.network.NetworkManager.channelRead0(NetworkManager.java:49)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.handleClientSideCustomPacket(NetworkDispatcher.java:383)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:269)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.channelRead0(NetworkDispatcher.java:72)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:443)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.local.LocalChannel.access$500(LocalChannel.java:49)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:397)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
[20:01:25] [Netty Local Client IO #0/INFO] [STDERR]: [org.cyclops.cyclopscore.network.PacketCodec:loopCodecFields:350]: 	at java.lang.Thread.run(Thread.java:748)
[20:01:25] [main/INFO]: [CHAT] A new §eOptiFine§f version is available: §eHD Ultra C8§f
[20:01:25] [Server thread/INFO]: Saving and pausing game...
[20:01:25] [Server thread/INFO]: Saving chunks for level 'WorldZ'/overworld
[20:01:25] [main/INFO] [STDOUT]: [com.cazsius.solcarrot.handler.MessageFoodList$Handler:handle:57]: List: []
[20:01:25] [main/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
	at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_162]
	at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_162]
	at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1086) [bib.class:?]
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397) [bib.class:?]
	at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_162]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_162]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_162]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_162]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]
Caused by: java.lang.NullPointerException
	at org.cyclops.integrateddynamics.core.network.packet.AllLabelsPacket.actionClient(AllLabelsPacket.java:41) ~[AllLabelsPacket.class:?]
	at org.cyclops.cyclopscore.network.PacketHandler$HandlerClient$1.run(PacketHandler.java:129) ~[PacketHandler$HandlerClient$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_162]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_162]
	at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
	... 17 more
commented

@fiws Are you using the latest Forge and ID version? That looks like a bigger problem in the network handler...

commented

@rubensworks Do you want me to test with the latest version of ID? I will need a newer CyclopsCore Dev Version in that case.

I tested with forge 14.23.1.2555

commented

@fiws No, shouldn't be the latest ID version. Any version compatible with that CC version will do.

commented

Thanks for checking.

Also the book somehow starts syncing again if you leave it open for like 2 minutes (for both cases)

@fiws Was there debug output in this case?

commented

In my attempt to reproduce this, I noticed that the last page position for the book is synced across worlds. I can reproduce this without any other mods. Is this wanted behaviour?

commented

I think I'm making progress here. I can reproduce … stuff. The bug seems to be related to the RFTools modular storage.

Setup

  • ID, Integrated Tunnels + Dependencies
  • All RFTools mods

Steps

  1. Start new world
  2. Run (far) away from the floating book
  3. Get a modular storage from rftools
  4. Get a menril tree (or find one) and chop it down
  5. Craft the Book IN the modular storage (which already seems buggy, as I have to store it as a recipe first to craft it)

Result

The book crafted seems to be the bugged editionβ„’. Weird stuff happens:

  • Create a new world and catch the floating book: somehow advancements got synced from the previous world
    OR
  • THE bug happens. And the book does not contain the "Meneglin Discovery" which i got by chopping down the tree before crafting. There also is NO debug output from cyclops core in that case.

I still don't know how to reproduce a specific result of those two. Also the book somehow starts syncing again if you leave it open for like 2 minutes (for both cases). πŸ˜“

(:angry: I hate this bug)

commented

hmm.. did not record that sorry, will do when i have time again. But I think there was nothing unusual. Just "normal" debug output.

commented

@JonnaJudin That's indeed a different issue, which has been fixed on 1.12. 1.10 is not maintained anymore.

commented

hi, having the same issue as in #261 with identical error log on the server on All The Mods 1.10.2 v.4 with integratedDynamics-1.10.2-0.7.14.jar and CyclopsCore-1.9.4-0.10.10.jar . I have no knowledge of mod dev, but looked into the stacktrace and available code in github based on this snippet in the stacktrace and was wondering few things:

at org.cyclops.cyclopscore.network.PacketHandler.sendToServer(PacketHandler.java:69) [PacketHandler.class:?]
	at org.cyclops.cyclopscore.infobook.pageelement.AchievementRewards.obtain(AchievementRewards.java:57) [AchievementRewards.class:?

64 /**
65     * Send a packet to the server.
66     * @param packet The packet.
67    */
68   public void sendToServer(PacketBase packet) {
>69        networkWrapper.sendToServer(packet);
70    }

Should this error be visible on server log, as I thought this part of the packethandler code runs on client only? I found similar issues on google, and those had server code being called on client or vice versa.
In my case I get the achievements and the book updates just fine, but on clicking the get reward button, error gets written on server log (standalone server) and the rewards are struck out as received in the book, but no rewards appear anywhere even though they are enabled in the config.

commented

@rubensworks I just encountered this in All the Mods 3. I was going to try your debugging to see if I can recreate and get some output for you but i noticed my CyclopsCores is 1.12.2-0.11.5.jar and the dev linked above is 0.11.1 . Am I safe to try that dev build out or do you have a more current dev build i can give a shot?

commented

@kingchills Not sure if it will work, the required version range might be too low. But you can try (after making a backup). Be sure to let me know how it goes. If it doesn't work, I'll prepare a new build.

commented

@rubensworks Yeah it gives me message about wrong dependency version for Integrated Dynamics and Integrated Tunnels. I could go grab old versions, should I grab old versions of those or do you want to kick out a new dev build?

commented

@kingchills Feel free to downgrade if you're up for it. I won't be able to provide a custom build in the next couple of days unfortunately.

commented

@rubensworks I'll give it a shot and see what I come up with. Just glad to try and help. I've really fallen in love with this mod and I'm glad you are working on it!

commented

GAH This has been maddening! I was able to downgrade the mods in a duplicated profile of ATM3. And i was able to reproduce the bug, but the the client-fml-latest.log was old and not updated. And I wasn't sure what log you were looking for. So i created a small pack just to test this, and was unable to reproduce it. Then I created a fresh world in my duplicate ATM3 profile and was unable to produce it. And i got frustrated and deleted all that. Then I loaded up my actual play through of ATM3 and it immediately happened on the 2nd and 3rd advancement i made! I'm going to take a break from this for a little bit and try again later tonight or tomorrow. Do you know is there a way to reset data, specifically when I start a new world and open the manual it's at the page I was last on, and often shows all the completed advancements from the previous world. In the older version i was also running into a couple of advancements not triggering at all, and I wasn't sure if that was a non related issue or not. It was Redstone Observement that wasn't triggering despite placing the created integer card created in Redstone Capturing in the display panel.

commented

GAH This has been maddening!

My feeling exactly for the last couple of months on this issue...

commented

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

commented

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

commented

lol. bad bot!

commented

Hopefully this is the right stuff! I got it to work by again creating a duplicate of my ATM3 profile, i loaded my game, and attempted to complete my next tutorials and the very first one didn't work. Here are screen shots showing i got the advancement, and the second after i had the book open.

2018-05-10_11 34 56
2018-05-10_11 35 01

Here is a gist of the latest.log
https://gist.github.com/kingchills/e6edb11d64c0c9a96c2d13591bcc30f8

I'm going to not touch this profile for now so if you need more information please let me know.

Gist
Log showing advancement not triggering book
commented

Hmm, I don't see anything in the logs...

I'll prepare a new dev build soon that emits some other debugging info.

Thanks for the help!

commented

@rubensworks Sounds like a plan! I'm glad to help, I know how frustrating it can be to get good information on a bug. Hopefully we can get to the bottom of this, I like getting my free goodies from doing the tutorial!

commented

I am running All the mods 3 as well. Also have this problem. Can test with the dev build when it is available.

commented

Alright, prepared a new CyclopsCore dev build (sorry for the delay): https://www.dropbox.com/s/9i40gqlt53ilcy5/CyclopsCore-1.12.2-0.11.5-DEV.jar?dl=0

@kingchills @interlamer Could try triggering an advancement that isn't synced with the book? If all goes well, you should see periodic CYCLOPSDEBUG lines in your logs. If so, please send me all the logs, I should be able to deduce from them what goes wrong.

commented

I repro this in the current ATM3 build (5.9.8c, July 1). Single player. I'm using the ID manual from Akashic Tome. Got the first set of achievements and got the rewards. Switched Akashic tome to some other manual. Switched back to the Integrated Dyamics manual, and while I still get the achievements (noted in console chat and viewable in the Achievements UI), the achievements don't trigger advancement in the book, so the rewards remain locked. Maybe it helps to know that AT is triggering the same bug as when people just use the ID manual directly?

commented

AT should not be able to cause the problem.

If someone would be able to use the dev-build of CyclopsCore I can start debugging this :-)

commented

I'm game to try that new build, if you can point me at some instructions for how to install it and where to find the logs you want to see.

commented

See my comment above from May 16th with a custom CyclopsCore build.

I'll just need the forge logs.

commented

I'm not a mod maker. I saw the post. I don't know what to do with that jar, or where the forge logs would be found.

commented

Ok, I finally managed to reproduce and debug this myself on a server. A fix will be released soon.

commented

@rubensworks Good to hear! After not being able to reproduce it or seeing anything in the logs I got kind of disheartened, but I'm glad it reared it's ugly head for you!

commented

finally
This took nearly half a year. Good for you, Ruben. Heisenbugs are awful.