Integrated Dynamics

Issue type:

Server crash occurred due to an apparent infinite loop causing a stack overflow error

🐛 Bug

Short description:

Crash occurred while transferring fluid.

Expected behaviour:

No crash.

Actual behaviour:

Crash.

Steps to reproduce the problem:

Unfortunately, crash is intermittent and can not be reliably reproduced. If we can determine a reliable crash condition, I will add to this thread.

Versions:

This mod: 0.11.9
CyclopsCore: 0.11.5
Minecraft: 1.12.2
Forge: 14.23.2.2611

Log file:

Crash report:
https://pastebin.com/qZEFcbMF

This seems really odd. Here's where this.children is used:

IntegratedDynamics/src/main/java/org/cyclops/integrateddynamics/api/network/IPositionedAddonsNetwork.java

Lines 145 to 148 in e725230

    
           public void invalidate() { 
        
               this.valid = false; 
        
               this.children.forEach(PositionsIterator::invalidate); 
        
           }

That implies that something has either itself or one of its ancestors as its child. And here's the only place that anything is added to this.children:

IntegratedDynamics/src/main/java/org/cyclops/integrateddynamics/api/network/IPositionedAddonsNetwork.java

Lines 176 to 177 in e725230

    
           PositionsIterator child = new PositionsIterator(this.collection); 
        
           this.children.add(child);

Note that the element being added to it is freshly constructed, so it can't possibly be itself or its ancestor.

It's possible that this occurs when the server has been running for a long time. I.e., when the following has been called a lot of times:

IntegratedDynamics/src/main/java/org/cyclops/integrateddynamics/core/network/PositionedAddonsNetwork.java

Line 65 in 5c8eec1

it = it.cloneState();

But I'd have to look into it in more detail to be sure.

Ah, so this is just the list becoming absurdly long, not actually infinite?

	public void invalidate() {
	this.valid = false;
	this.children.forEach(PositionsIterator::invalidate);
	}

	PositionsIterator child = new PositionsIterator(this.collection);
	this.children.add(child);

Share to