Integrated Dynamics

Integrated Dynamics

63M Downloads

CraftTweaker Wiki Entries

NielsPilgaard opened this issue ยท 10 comments

commented

Issue type:

  • ๐Ÿ› Bug

Short description:

The MineTweaker section of the wiki, https://github.com/CyclopsMC/IntegratedDynamics/wiki/MineTweaker, is outdated, the addRecipes take other parameters than specified.

commented

Does it though? I don't remember changing this recently.

What problems are you running into with the wiki's examples?

commented

It does yes. According to the wiki, Squeezer.addRecipe can only take inputStack, outputStack, outputFluid, but it actually has 4 different parameter options.

inputStack, outputStack
inputStack, outputStack, outputFluid
inputStack, outputStack, int chance, secondaryOutputStack
inputStack, outputStack, outputFluid, int chance, secondaryOutputStack

The same goes for the mechanicalSqueezer. The duration parameter does not seem to exist.

commented

You're right, I'll have to look into that.

Note to self: chance variants are not documented yet: https://github.com/CyclopsMC/IntegratedDynamics-Compat/blob/master-1.12/src/main/java/org/cyclops/integrateddynamicscompat/modcompat/minetweaker/handlers/SqueezerHandler.java

GitHub
Integrated Dynamics compatibility with other mods. - CyclopsMC/IntegratedDynamics-Compat
commented

Thanks :) Luckily the error is fairly descriptive.

commented

Updated the wiki page. Also added some new convenience CT variants while I was at it. These will be included in the next update.

commented

After updating to IntegratedDynamics-1.12.2-1.0.7, all my scripts using the syntax inputStack, outputStack, int chance, secondaryOutputStack are broken. They also throw errors if I change the int chance to float or double. They worked prior to updating.

commented

Is your issue the same as CyclopsMC/IntegratedDynamics-Compat#21?
If so, it has been fixed. (will try make a new release somewhere next week)

commented

Yep that's it, sorry for the duplicate :)

commented

@NillerMedDild I'll make a new release with this fix in a bit. It may be possible that you'll have to change your scripts slightly to inputStack, outputStack, int chance, secondaryOutputStack, secondaryOutputStackChance.

The reason for this is that I removed some @Optional annotations because CT seems to be randomly breaking things when they are used in multiple equal-named methods. You can just use 1 for these chances if they are not important though.

commented

Sounds reasonable, thank you :)