Integrated Dynamics

Integrated Dynamics

63M Downloads

Add (unique) aliases for long operator names

Krutoy242 opened this issue ยท 3 comments

commented

Issue type:

  • ๐Ÿ› Bug

Short description:

Operator Operator By Name cant work with actual names of operators such as +, -, get, contains. Instead it working with ridiculous long names like

"operator.operators.integrateddynamics.list.uniq_p.name"
"operator.operators.integrateddynamics.parse.valuetype.valuetypes.integrateddynamics.integer.name"

Also, this long names listed in NBT.value of operator card

{
  _type:"valuetype",
  typeName:"valuetype.valuetypes.integrateddynamics.operator.name",
  _id:104,
  value:"operator.operators.integrateddynamics.parse.valuetype.valuetypes.integrateddynamics.integer.name"
}

Versions:

  • This mod: 1.1.2
  • Minecraft: 1.12.2
  • Forge: 14.23.5.2847
commented

calling these names ridiculous is not really appropriate here

Sorry, im Russian and sometimes may use wrong words to describe situation.

I see no reason for calling this a bug

Can i then edit this issue to Feature Request? It would be intuitive if names have short aliases.

Even if this long names intended, String card can be made only with 64 symbols, and this line is 96, so i cant test how Operator By Name work (without additional steps to create long string)

operator.operators.integrateddynamics.parse.valuetype.valuetypes.integrateddynamics.integer.name

commented

Operators are identified by internal names (like operator.operators.integrateddynamics.list.uniq_p.name), not by their shorthands.
These shorthands only exist for the sake of visualization in the LP, but they do not uniquely map to operators (such as the cast operators), and can therefore not be used as input to Operator By Name.

So calling these names ridiculous is not really appropriate here, they are used for a good reason. Hence, I see no reason for calling this a bug.

Does this satisfy as an answer to you?

commented

The 64 limit indeed looks like a problem (reported in #841).

And sure, I can make this a feature request.