Integrated Dynamics

Integrated Dynamics

63M Downloads

Placing Variable Card in Display Panel causes the game to crash

Ararem opened this issue ยท 10 comments

commented

Issue type:

  • ๐Ÿ› Bug

Short description:

I have a variable card made up of a few strings and int's appended onto an empty list. Any time I try to place the final card into a display panel, the game crashes immediately. (All the variables are reading from a TileEntity's NBT).

Note: The display panel dissappears, while the cable glitches out visually.
2020-06-14_14 37 11

Steps to reproduce the problem:

Unknown, card on 1st TileEntity worked, 2nd card (different values, same principle and setup) crashes.

Expected behavior:

The variables are concatenated and the result is displayed.


Versions:

  • IntegratedDynamics-1.12.2-1.1.2, IntegratedTunnels-1.12.2-1.6.10
  • Minecraft: 1.12.2
  • Forge: 1.12.2 - 14.23.5.2847

Log file:

https://pastebin.com/7UjkcwC6

commented

@EternalClickbait Could you share your full Forge log? I assume some other error occurred before this one.

commented

A quick bit of testing shows that as soon as I append 2 values onto a list, it crashes. At the moment it's List(Any) + NBT.String + NBT.Integer which causes the crash. I also had one very weird glitch where all my inventory got swapped around, and then it fixed itself after a second (this happened as soon as I placed in the card). The card returned to my inventory, and on the second attempt it crashed.

commented

Another edit, I believe this to be an NBT value conversion error. My original (working) cards were using NBT.Integer to get an int value, but the crashing ones were using NBT.String. I fixed the aspect on the cards and I no longer get any errors/crashes.

commented

I'm afraid I've deleted those logs, but I'll try and reproduce the error again and upload the logs.

commented

Ok so I got it reproduced. One very weird thing is if I insert the 'breaking' list before the cards it requires, my entire inventory goes weird and the display panel dissappears (but not visually). If I insert the 'breaking' card after it's components, the game crashes.
2020-06-17_19 44 12
2020-06-17_19 44 29

Crash file + Logs + Recording are too large for GitHub, here's a google drive link to the zip https://drive.google.com/file/d/1_eYgmU2kyb5MVeetK6yCa8wwsE5jQ3vf/view?usp=sharing

Google Docs
commented

Thanks!

commented

Ok, so the problem seems to be caused by erroring tile entities, which are being reset behind the scenes, and cause a crash later on.

I was unfortunately not able to reproduce this problem myself, but with your logs I was able to pinpoint the possible cause, and add some debug information to the logs.
@EternalClickbait Could you try out the latest dev build (see README of this repo), and share the full logs with me again after the crash?

commented

May be related to #866 if map operations were used.

commented

I've tried to reproduce it, but for some reason it is no longer crashing. When trying to get an NBT value using the wrong type, it simply displays the default value, so I assume you fixed whatever it was. BTW I used v1.12.2-1.1.7

Edit: Heres the log
latest.log

commented

@EternalClickbait Thanks for checking, seems like it was fixed in #866 then.