Crash with clientcommands - LockedSlotKeeper assumes container doesn't change
Earthcomputer opened this issue · 9 comments
Hi, I've looked briefly into a crash reported to clientcommands here and I think there is an issue in LockedSlotKeeper where it implicity assumes the container doesn't change by storing some slot ids, although I didn't fully understand what's going on yet. Clientcommands changes the open container when a container GUI is opened here. I was wondering if you could provide some insight into what's going on?
To reproduce, install clientcommands and inventory profiles next, join a world, place some dirt in a chest, then type /cfinditem dirt into chat.
"Fix/Workaround" will be available in the next release. However 1.19.3 is no longer supported and will not receive the fix.
Yeah LockedSlotsKeeper is a mess I'm trying to make my self clean for a long time.
It should detect if a GUI is open and stop doing any thing until it's closed. But my guess is it happens to fast to be detected.
The assumption is that i works on the normal player inventory which is available even if it's not open.
Oh my lord, the reason for the crashes was the version difference, updating libIPN and Inventory Profiles Next solved the issue
Edit: Welp, maybe not-
Well I'm happy it's fixed 😁
I have the new version spam on startup for a reason 🤣
edit Well it sounded too good lol
Yeaaaah, I was kinda afraid that it wasn't going to be easy... do you want to chat on Discord so we're not clogging Github?