Inventory Profiles Next

Inventory Profiles Next

24M Downloads

(1.16.5) Swap row and column sorting functionality

Gann4Life opened this issue ยท 10 comments

commented

This is a suggestion to swap functionality for buttons sorting in columns and rows, to make it more intuitive to read.
It might be something subjetctive too so if i'm heavily musunderstanding this, let me know and i'd love to see any explaination.

Sort in columns

image
I am expecting to see items sorted like in the button, but it does not happen and makes me feel confused, the text used to feel weird to me, but i think i get what it means by "column".

Sort in rows

image
Literally same as above but for rows:
I am expecting to see items sorted like in the button, but it does not happen and makes me feel confused, the text used to feel weird to me, but i think i get what it means by "rows".

Conclusion

I'm expecting to see items sorted the same as the button represents, the first time i used the mod it made me feel confused about how items were being sorted and i hope it makes sense for everyone too, i think that swapping the button icons will make everything feel more obvious and intuitive, maybe the texts were used in a programmer's view and not from a user point of view.

I'm not a minecraft modder yet, if i could i'd do this myself and try to contribute with the project, i'm sorry if this detail is too small for something to be done about it.

commented

I haven't really messed with the sorting code so I guess the buttons are reversed in the original mod too.

I'll check it.

commented

I've used these buttons more times and sometimes it does the right job but sometimes it doesnt as i've shown in this "post", and now this is weird and probably has bugs, or maybe its behaving as it should, i'm not really sure, but i'll share more screenshots

Column sorting

image

Row sorting

image

Side comment: Thanks for making this fork and continuing with the mod, i didn't expected such a quick answer :)
Take your time, wish you a good day/noon/night.

commented

fixed in bb1ef68

commented

I just checked and it is as you've said.

This is the bug I'm experimenting (with a lot of item types):
2022-09-01_12 46 34

2022-09-01_12 46 44

And with a few item types it works as expected:
2022-09-01_13 13 20

2022-09-01_13 13 32

commented

with lots of item types it just looks like it's the opposite.
also sort doesn't ignore durability and the bows for example are considered different items. So in the first screenshot you have 6 columns of bows and not 2 rows of bows

commented

Still having this issue with version 1.7.0 for Minecraft 1.18.2.

commented

can you post a screen shot

also can you test with 3 - 4 item types only because if the item types are too many it looks like columns and rows swap

commented

Having the same problem, attaching screenshots.

This is a quite simple example, only three different items. The potatoes and wheat aren't indicating any grouping as seen by the glowstone dust seperating them, which is fine, but the buttons seem to be reversed.

Minecraft 1.19.2
Fabric Loader 0.14.9
IPN 1.8.2

image

image

commented

Game and loader versions?

commented

Minecraft 1.19.2
Fabric Loader 0.14.9
IPN 1.8.2