Inventory Sorter

Inventory Sorter

52M Downloads

[1.10.2] Spice of Life Lunchbox Dupe

xSparky911x opened this issue ยท 2 comments

commented

In a multiplayer server, when scrolling food from the Lunchbox the game does a temporary freeze and kicks you from the server but does not crash the game. When you join back in you have an extra food item in your inventory and still the same one in the Lunchbox. Not sure if this is caused by Spice of Life or Inventory Sorter based on the log. Does not seem to happen in single player

Forge: 2221
Inventory Sorter: 0.10.5+46

Log: http://pastebin.com/PhMyJS4L

commented

I can't reproduce this locally. Here's the code in question, which should protect against this error:

if (FMLCommonHandler.instance().getEffectiveSide() == Side.CLIENT)
{
	findMatchingClientItemStack();
}

My best guess is that it might be somehow related to #33?

EDIT: Still unable to reproduce FMLCommonHandler.instance().getEffectiveSide() == Side.CLIENT within the network thread of a message handled on Side.SERVER, so I really don't know what could be causing this.

commented

Should be fixed with 1.12. I moved the processing to the server thread.