Inventory Sorter

Inventory Sorter

54M Downloads

[Bug] [1.12.2] Sorting hotbar dupes item

ldcn opened this issue ยท 3 comments

commented

When sorting hotbar (with middle click) while inside the GUI of a refined storage wireless crafting grid (or any other refined storage wireless item), it will dupe the item, the dupe taking an empty space in the hotbar. If the hotbar is full, the dupe will replace one (non-refined storage) item until the entire hotbar is filled with wireless crafting grids.

I've been able to reproduce this every time. Tried with other handheld items with GUIs and the dupe does not occur.

This happens in the direwolf20 1.12 modpack version 1.3.0

server log when dupe happens (with RS wireless crafting grid):

[00:21:32] [Server thread/DEBUG] [inventorysorter]: Got action SORT slot 9 [00:21:32] [Server thread/DEBUG] [inventorysorter]: Slot mapping {net.minecraft.inventory.InventoryBasic@1f316d51=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=4, e=12}, net.minecraft.inventory.InventoryBasic@5bde05a7=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@5bde05a7, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=0, e=3}, net.minecraft.inventory.InventoryCraftResult@5c0654bc=InventoryMapping{i=net.minecraft.inventory.InventoryCraftResult@5c0654bc, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=49, e=49}, net.minecraft.inventory.InventoryBasic@307d42d6=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@307d42d6, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=13, e=39}, net.minecraft.inventory.InventoryCrafting@17faf194=InventoryMapping{i=net.minecraft.inventory.InventoryCrafting@17faf194, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=40, e=48}} [00:21:32] [Server thread/DEBUG] [inventorysorter]: Action slot InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=com.raoulvdberge.refinedstorage.container.ContainerGrid@724cc05, b=4, e=12} [00:21:32] [Server thread/DEBUG] [inventorysorter]: Item 1xitem.petal@3 is not valid in slot 4 of container com.raoulvdberge.refinedstorage.container.ContainerGrid

with non-RS item (in this case, Traveller's Sack from Actually Additions):

[00:22:43] [Server thread/DEBUG] [inventorysorter]: Got action SORT slot 65 [00:22:43] [Server thread/DEBUG] [inventorysorter]: Slot mapping {net.minecraft.inventory.InventoryBasic@1f316d51=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=59, e=67}, net.minecraft.inventory.InventoryBasic@307d42d6=InventoryMapping{i=net.minecraft.inventory.InventoryBasic@307d42d6, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=32, e=58}} [00:22:43] [Server thread/DEBUG] [inventorysorter]: Action slot InventoryMapping{i=net.minecraft.inventory.InventoryBasic@1f316d51, c=de.ellpeck.actuallyadditions.mod.inventory.ContainerBag@5838dad7, b=59, e=67} [00:22:43] [Server thread/DEBUG] [inventorysorter]: Slot 63 of container de.ellpeck.actuallyadditions.mod.inventory.ContainerBag disallows canTakeStack

This is probably the same problem as #30

commented

same problem, switched to Inventory Tweaks

commented

Same issue here. Due to the nature of the items it affects my intuition tells me it has something to do with the way bags/wireless grids lock themselves to the slot on opening (to prevent inserting a grid/bag inside itself).

commented

Yeah, this is technically a bug in the other mods: they're not properly preventing the slot from being useable, so when I sort it's considered a candidate for sorting. Generally I'll just blacklist broken containers like this until the mod fixes it. (Slot.cantakestack is returning true when it should not)