Inventory Sorting

Inventory Sorting

15M Downloads

Click to hide button does nothing

manchesterjm opened this issue ยท 11 comments

commented

Have you updated to the latest version?

  • I swear I have tried it with the latest version!

What happened?

When hovering over the sort button there is a text box that states you can hold left ctrl and then click the button to hide it. Doing this does not hide the button.

Image

What did you expect to happen?

I expected it to hide the button

Operating System

Windows

What's the filename of the mod you are using?

inventorysorter-fabric-2.0.10+mc1.21.6.jar

Minecraft Version

1.21.6

Logs

No response

commented

Oh how embarrassing :D It sure is! No need to open a new one, I'm on it :D

commented

Ah, technically not a bug, just confusing UX.

So the "Sort button in player inventory" only applies when there is another container open. It's basically setting if there should be 2 buttons or 1. But when it's only your own inventory open, there's only 1 button so it shows it.

The "Sort Button" setting is what turns all buttons off and on

Still, not really clear is it

commented

Ah, I guess a pop up tip could address that easily enough.

commented

This one is a fun find! So that button is your player inventory button and hiding it would hide it from anywhere you see your own inventory. I'm not sure if the solution here is to remove the text telling you you can CTRL+Click hide it and only keep the configuration screen for this, or to allow the ctrl+click hide.

What do you think?

commented

The funny thing is that I wasn't going to report the first bug (the button covers the off hand slot) if I could just hide it. If it does in fact hide it in all interfaces then that would be a bad thing, so maybe eliminating the text that says you can hide it is the quick and easy fix. It's what I would do personally.

commented

Yeah, the "hide on click" is for the buttons that appear for specific containers. When you have a modded chest that really messes with the button, you could hide it.
The player inventory button is a different concept.

commented

That must be a PITA to get that button to appear where it should for customized interfaces or other mods so having that hide function is most appreciated. But, I am just running it on my home server and I don't heavily mod as I like the vanilla experience with a few QoL mods so using the hide feature doesn't really apply to me. I just noticed that it didn't work when I tried it and it was advertised as something that could be (should be?) done.

commented

You can hide the button for now in the config screen until I patch it.

Either one of these should help for now

Image

commented

thanks, I'll do that until it is updated. And thanks for looking at this so fast. Considering it is the middle of the week I wasn't expecting a reply until tomorrow.

commented

Image

Image

Lol, I turned it off and the button persists. Is that a new bug also?

commented

๐ŸŽ‰ This issue has been resolved in version 2.0.11 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€