Inventory Tweaks [1.12 only]

Inventory Tweaks [1.12 only]

127M Downloads

Sorting crashes when attempting to sort a chest of bees

Somethingwoo opened this issue ยท 4 comments

commented

Bug: Sorting an inventory with NBT-identical bees that are not stacking normally will lock up the client. No crash logs or such are produced as this is a client lockup (InvTweaks is caught in an infinite loop going "this should stack, let's stack them" and the bees of course won't stack).

commented

Please include the specific Inventory Tweaks version in all reports.

commented

Crash/hang happening on InventoryTweaks-MC1.6.2-1.56-b77 (DW20 pack)
Bees and Thaumcraft mana beans both seem to be problematic. It doesn't have to be full chest, more than half of a diamond chest seems to be enough to hang when sorting. Also, it doesn't always happen, an already sorted chest will likely survive. It seems to hit she sweet spot when you divide a stack (bees/beans) and then try to sort.

Forge console will be outputting lines like this

2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 48 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 4186 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 8372 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 12423 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 16684 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 21035 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 26106 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 31308 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 33278 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 38573 to go! 
2014-01-01 23:03:04 [WARNING] [Minecraft-Server] Memory connection overburdened; after processing 2500 packets, we still have 44002 to go!
commented

Have nailed it down, easy to reproduce. Take an empty chest, 2 Thaumcraft mana beans of the same type (2 stackable bees could also work). When you put them in 2 different slots in the empty chest, default sorting will not stack them (but should). When using row/coumn sorting, it hangs.

commented

Recent build shouldn't freeze on sorting (by just screwing with 'I couldn't move this, try again' so it doesn't reset all the time)

It should be stacking, I'll have to look at that sometime but my working copy is fairly broken due to being half-updated to 1.7.