Calculator Mod Incompatibility

Question

Calculator Mod Incompatibility

SonarSonic opened this issue 10 years ago · 17 comments

SonarSonic commented 10 years ago

Hey,
I'm the creator of the Calculator Mod. I've been getting glitches which cause my mod to be unplayable it only ever occurs when Inventory Tweaks is installed. The bug is difficult to explain so there is a video below. I tried using the @IgnoreContainer annotation but It didn't seem to disable the container in any way and logger still showed Inventory Tweaks had loaded it.

I should probably say this only happens with portable items which have containers e.g. Calculators.
Also this doesn't happen every time you open the container about once every 3 times.

Video of glitch
https://youtu.be/jIIrX1poZC4

Basic Calculator Container
http://pastebin.com/hkfpXz5U

SonarSonic · Answer 1 · 2015-09-30T11:37:30.000Z

Wasn't inv tweaks in the end but it's fixed now.

SonarSonic · Answer 2 · 2015-08-02T23:23:59.000Z

Okay people are still reporting the glitch. The only people who report it are ones who have Inv-Tweaks installed, any ideas?? Thank you :)
SonarSonic/Calculator#9 (comment)

Kobata · Answer 3 · 2015-08-03T19:13:43.000Z

No idea, I'm not seeing anything using just shift in my shortcut code by default.

SonarSonic · Answer 4 · 2015-08-03T21:09:55.000Z

do you edit any Minecraft base code?

Kobata · Answer 5 · 2015-08-03T21:11:16.000Z

A bunch of special additions for metainfo about containers, but the only thing that actually changes any base method is the 'stop processing keys when a textbox is selected' code.

SonarSonic · Answer 6 · 2015-08-03T21:13:41.000Z

So strange :/ Could it be a fault with my code? It's just so strange that it only comes up with inv tweaks

SonarSonic · Answer 7 · 2015-08-03T21:15:46.000Z

Do you do anything with?

public ItemStack slotClick(int slot, int button, int flag, EntityPlayer player)

or

public boolean func_94530_a(ItemStack stack, Slot slot)

Kobata · Answer 8 · 2015-08-03T21:22:32.000Z

slotClick is called from all over as it's the only way to move items around from the client without absolutely requiring a server-side mod.

I don't see any references to canMergeSlot(94530) in current version at least.

SonarSonic · Answer 9 · 2015-08-03T21:24:02.000Z

@Override
public ItemStack slotClick(int slot, int button, int flag, EntityPlayer player) {
    if (slot >= 0 && getSlot(slot) != null && getSlot(slot).getStack() == player.getHeldItem()) {
        return null;
    }
    return super.slotClick(slot, button, flag, player);
}

SonarSonic · Answer 10 · 2015-08-03T21:24:18.000Z

Could this be a problem?

Kobata · Answer 11 · 2015-08-03T21:27:41.000Z

If you're triggering a sort it might cause an infinite loop freeze if that's the only thing you do to prevent moving (and there's something set up with higher priority for that hotbar slot, as usually they aren't changed)

That's not the issue showing up though.

SonarSonic · Answer 12 · 2015-08-03T21:29:46.000Z

So maybe I should change the way I do that and it will be okay?

Also I override this

public boolean func_94530_a(ItemStack p_94530_1_, Slot p_94530_2_) {
return p_94530_2_.inventory != this.craftResult && super.func_94530_a(p_94530_1_, p_94530_2_);
}

Kobata · Answer 13 · 2015-08-03T21:35:01.000Z

I don't directly use that, or ever send a click that should call it.

SonarSonic · Answer 14 · 2015-08-03T22:28:09.000Z

okay. I'll change the slot click methods and see if that works

Kobata · Answer 15 · 2015-04-05T12:22:33.000Z

The only thing I can see that looks really suspicious is your definition of slotClick.

InventoryTweaks doesn't do anything unless specifically told to however, either by using the sorting buttons or a hotkey -- and unless you've told it about your container somehow it practically entirely disables itself.

SonarSonic · Answer 16 · 2015-04-05T13:02:34.000Z

Okay, i'll have a look into replacing that. Thank you.

SonarSonic · Answer 17 · 2015-04-05T16:20:35.000Z

Removing the method entirely made no difference. I then removed inventory tweaks again and the glitch disappeared again.

EDIT: It's doesn't seem to be happening anymore :/ I think maybe the glitch might have something to do with server lag possibly.
One thing I noticed was that for Calculators I used player.openGui instead of FMLNetworkHandler.openGui but I don't think that would make a difference

Share to