
[Incompatibility]: Deeper Darker & Fabrishot
Fyoncle opened this issue ยท 10 comments
Describe the bug
This issue is pretty confusing, and only happens if BOTH InvMove and Fabrishot are present.
When you try to use Soul Elytra of the Deeper Darker and attach the boost keybind to Shift or any other key that is not letter such as CTRL, TAB, ESC, ALT, it wont work if both InvMove and Fabrishot present, but if one of these mods removed, Shift, CTRL, and all the other that type of keys work.
With InvMove and Fabrishot only letters work such as A B C D E F G
To Reproduce
- Install Deeper & Darker
- Install Fabrishot
- Install InvMove
- Bound Deeper & Darker Soul Elytra Boost Key To Shift
- Wear Soul Elytra
- Try To Boost and see its broken
- If either InvMove removed, it works with Fabrishot, if Fabrishot removed, it works with InvMove.
Version and Mod List
InvMove: 0.8.4
Deeper Darker: 1.3.2.1
Fabrishot: 1.10.1
Fabric Version: 0.16.9
Minecraft: 1.20.1
I didn't know where to report this so ill just report it here and send it over to the other issues.
Hmm interesting, it seems to work fine for me using the same versions you listed, but maybe I'm missing something
There's a chance this might be fixed already for the next release though:
If you go here: https://github.com/PieKing1215/InvMove/actions/runs/11759358978
and scroll down to artifacts and download that zip, there's a InvMove-0dfad37+1.20.1-Fabric.jar
inside
If you get a chance can you try and see if that fixes it?
There's some changes to how I handle keybinds that might be relevant
(note with the new version you'll have to explicitly allow the boost keybind in InvMove's config screen for it to work inside inventories (UI Movement -> Allowed Keys))
Now i can't reproduce with the steps i provided either, but i still have the pack that bug was in, and bug still remains in this pack, so im binary searching for the fifth time to make sure stuff, one momento :D
Started to make some progress after hours of binary searching, there is like 6th and 7th incompatibility, wtf?
Now the folder i suspected and actually caused the glitch doesn't anymore all of a "sudden" i'm really confused, i'm about to lose my mind!
I'm about to go crazy :D it's 03:32 AM. I'll just drop the mrpack and sleep now, maybe ill continue searching tomorrow, but im tired of this chaos.
https://modrinth.com/modpack/elysium-days/version/6.0.0 This version should have the glitch.
https://mclo.gs/25PrkS8
Artifact works with vanilla test, but crashes on my modpack
I'm about to go crazy :D it's 03:32 AM. I'll just drop the mrpack and sleep now, maybe ill continue searching tomorrow, but im tired of this chaos. https://modrinth.com/modpack/elysium-days/version/6.0.0 This version should have the glitch.
Maybe could be some kind of issue where it only happens some times you launch the game? If it's like that it makes binary searching more annoying
Either way no rush, I can look into it too
https://mclo.gs/25PrkS8 Artifact works with vanilla test, but crashes on my modpack
Oh if you have InvMoveCompats you'll have to disable it to use the artifact version for now (it'll get updated too but it's wip)
I'm about to go crazy :D it's 03:32 AM. I'll just drop the mrpack and sleep now, maybe ill continue searching tomorrow, but im tired of this chaos. https://modrinth.com/modpack/elysium-days/version/6.0.0 This version should have the glitch.
Maybe could be some kind of issue where it only happens some times you launch the game? If it's like that it makes binary searching more annoying Either way no rush, I can look into it too
https://mclo.gs/25PrkS8 Artifact works with vanilla test, but crashes on my modpack
Oh if you have InvMoveCompats you'll have to disable it to use the artifact version for now (it'll get updated too but it's wip)
Artifact doesn't fix it... :(
Ok so I investigated this and figured it out:
Setting boost to shift obviously overlaps with sneak
But because of the way the vanilla key press code works it only keeps track of one control for each physical key.
So what's happening is that it'll only trigger either sneak or boost, but not both (eg. notice if you have a set of mods where shift to boost works you can't sneak)
And the order the keys are inserted into the map probably changes depending on what mods you have, what keybinds they add, loading order, etc. so it seems basically random
So the issue isn't actually related to InvMove or Fabrishot, you can notice sneak not working with just DD & its dependencies
You can get something like Keybind Fix (or similar) to fix it: https://modrinth.com/mods?q=keybind+fix
Ok so I investigated this and figured it out: Setting boost to shift obviously overlaps with sneak But because of the way the vanilla key press code works it only keeps track of one control for each physical key. So what's happening is that it'll only trigger either sneak or boost, but not both (eg. notice if you have a set of mods where shift to boost works you can't sneak) And the order the keys are inserted into the map probably changes depending on what mods you have, what keybinds they add, loading order, etc. so it seems basically random So the issue isn't actually related to InvMove or Fabrishot, you can notice sneak not working with just DD & its dependencies
You can get something like Keybind Fix (or similar) to fix it: https://modrinth.com/mods?q=keybind+fix
That's pure brain rot to understand how it works but thank you for saving me from overthinking this now xD