Iris & Oculus Flywheel Compat

Iris & Oculus Flywheel Compat

22M Downloads

Crash when Create Portable Storage Interface's connect

foxynotail opened this issue ยท 9 comments

commented

Error: Not filled all elements of the vertex

Doesn't happen every time.
Strangely, this mostly happens when shaders are not enabled.

I propose that this mod is worked so that it does not do anything at all, unless a shader is enabled.

commented

Can confirm, suffering the same crashes. I was able to reproduce this :

  • without any shader enabled
  • both on Fabric (with Iris) and Forge (with Oculus)

Here's some crash reports :

If necessary, i can provide reports from other players on the server i'm playing with.

Hope this helps!

commented

Same for me on forge 1.20.1 with this mod and like foxy's, mostly happens when shaders are off.

It also seems to happen when I change a deployer's mode.

Here's a crash report from me:
crash-2024-06-16_22.09.08-client.txt

Hope this helps!

commented

fabric 1.20.1
crash-2024-06-22_16.53.32-client.txt
Hope this helps

commented

Can confirm
Fabric 1.20.1, only crashing when shaders are disabled.
crash-2024-06-29_16.56.41-client.txt

commented

Any one try this?
Delete this line,

Still crash
Not having crashing issue for 1 hour.

commented

This is a real problem, added this to my modpack and now I have tons of crash reports all related to this problem. This is very urgent.

commented

This is a real problem, added this to my modpack and now I have tons of crash reports all related to this problem. This is very urgent.

oculus-flywheel-compat-1.20.1-0.2.6.jar.zip

@@ -31,13 +33,13 @@ public class MixinBufferBuilder implements BufferBuilderAccessor {
         extending = extending && BufferBuilderStateManager.isAllowExtend();
     }*/
 
     @ModifyVariable(method = "begin", at = @At("HEAD"), argsOnly = true)
     private VertexFormat iris$extendFormat(VertexFormat format) {
-        if(!BufferBuilderStateManager.isAllowExtend()){
+        if (!BufferBuilderStateManager.isAllowExtend()) {
             extending = false;
-            return DefaultVertexFormat.BLOCK;
+            if (IrisApi.getInstance().isShaderPackInUse())
+                return DefaultVertexFormat.BLOCK;
         }
-
         return format;
     }
 }

with this change made, i am not facing crashing issues for couples of weeks,
you could try it

commented

This is a real problem, added this to my modpack and now I have tons of crash reports all related to this problem. This is very urgent.

oculus-flywheel-compat-1.20.1-0.2.6.jar.zip

@@ -31,13 +33,13 @@ public class MixinBufferBuilder implements BufferBuilderAccessor {
         extending = extending && BufferBuilderStateManager.isAllowExtend();
     }*/
 
     @ModifyVariable(method = "begin", at = @At("HEAD"), argsOnly = true)
     private VertexFormat iris$extendFormat(VertexFormat format) {
-        if(!BufferBuilderStateManager.isAllowExtend()){
+        if (!BufferBuilderStateManager.isAllowExtend()) {
             extending = false;
-            return DefaultVertexFormat.BLOCK;
+            if (IrisApi.getInstance().isShaderPackInUse())
+                return DefaultVertexFormat.BLOCK;
         }
-
         return format;
     }
 }

with this change made, i am not facing crashing issues for couples of weeks, you could try it

Can you make a PR so the author publish the fix?

commented

@Rodrigo816
Its just avoiding crashings instead of fixing the actual problem, so..