Iris Shaders

Iris Shaders

36M Downloads

Crash with malformed geometry shaders

gri573 opened this issue · 3 comments

commented

Minecraft Version

1.18.1

Iris Version

iris-mc1.18.1-1.2.0-pre.jar

Sodium Version

sodium-fabric-mc1.18.1-0.4.0-alpha6+build14.jar

Operating System

linux (ubuntu 21.10)

What is your GPU?

AMD vega 8

Java Version

java 16 (bundled)

Reproduction Steps

attempt to load a shaderpack that has a syntax error in a geometry shader

Test shader pack to reproduce issue:
crash_geometry_shaders.zip

Crash Report:
crash-2022-02-04_16.20.50-client.txt

latest.log:
latest.log

Crash Report file and latest.log

No response

Additional context

No response

commented

Resolved in #1257

commented

We crash the game if Sodium shader compilation fails, since that almost always indicates a patcher issue. In this case it doesn't since we don't compile geometry shaders for vanilla (there's a PR for that though)

commented

This should probably fall back, with an error message about improper syntax instead of outright crashing, right?