Iris Shaders

Iris Shaders

36M Downloads

GH Actions should not upload artifacts

Opened this issue ยท 6 comments

commented

What happened?

According to #1249, the GH Actions setup should not upload artifacts, while in https://github.com/IrisShaders/Iris/actions/runs/2659997640 I can very clearly see them.

Screenshots

image

commented

It looks like this change was made on 0e8639b, I'm surprised this PR got merged but not mine?

commented

Actually no, the change was made on 6ee89c8, why? And the same person also commited this? 5568b64

commented

I quote coderbot from the last mentioned commit 5568b64:

In the past we prevented this to avoid spurious issue reports. But it is clear now that it is more important to continuously be testing our development branches to ensure that bad bugs aren't popping up and not getting spotted until later.

so the actions were enabled again on purpose

commented

I quote coderbot from the last mentioned commit 5568b64:

In the past we prevented this to avoid spurious issue reports. But it is clear now that it is more important to continuously be testing our development branches to ensure that bad bugs aren't popping up and not getting spotted until later.

so the actions were enabled again on purpose

image

I don't see that anywhere in the commit message

commented

sorry i mentioned the wrong commit, this is the correct one 6ee89c8

commented

This was a recent decision change, encouraged by some of the regressions that popped up during 1.2.5's development.