Iris Shaders

Iris Shaders

Mods
38M Downloads

When water reflections are enabled in Sildur's Vibrant Shaders and the player is in a column of water surrounded by air, world geometry will completely fail to render in Minecraft 1.19, 1.18.2 and 1.17.1 (but NOT 1.16.5) in combination with pretty much every modern version of Iris, including Iris 1.2.5

akemin-dayo opened this issue · 6 comments

commented

What happened?

(Sorry for the really long issue title, it was a challenge trying to summarise the bizarre nature of this bug ;P)

When water reflections are enabled in Sildur's Vibrant Shaders and the player is in a column of water surrounded by air, world geometry will completely fail to render.

The following Minecraft + Iris version combinations are affected:

  • Minecraft 1.19 + Iris 1.2.5
  • Minecraft 1.18.2 + Iris 1.2.5
  • Minecraft 1.18.2 + Iris 1.2.4-build.38
  • Minecraft 1.18.2 + Iris 1.2.3-build.35
  • Minecraft 1.17.1 + Iris 1.2.5
  • Minecraft 1.17.1 + Iris 1.2.4-build.37
  • Minecraft 1.17.1 + Iris 1.2.3-build.34
  • Minecraft 1.17.1 + Iris 1.2.2-build.31
  • Minecraft 1.17.1 + Iris 1.2.1-rc1-90bdb008

The following Minecraft + Iris version combinations are NOT affected:

  • Minecraft 1.18.1 + Iris 1.2.0-pre
  • Minecraft 1.17.1 + Iris 1.2.0-pre
  • MInecraft 1.16.5 + Iris 1.2.5
  • MInecraft 1.16.5 + Iris 1.2.4-build.36
  • MInecraft 1.16.5 + Iris 1.2.3-build.33
  • MInecraft 1.16.5 + Iris 1.2.2-build.30
  • MInecraft 1.16.5 + Iris 1.2.1-rc1-20f1aa54
  • MInecraft 1.16.5 + Iris 1.2.0-pre

※ I tried to test these Minecraft + Iris version combinations in an attempt to further bisect this issue to make your lives easier, but I can't remember the correct combination of Sodium + Fabric API versions required to get these old builds to work and not immediately crash at startup. If you guys keep that documentation around, these versions may possibly be worth exploring to try to bisect the issue.

  • Minecraft 1.18.2 + Iris 1.2.2-build.32
  • Minecraft 1.18.2 + Iris 1.2.1-rc2-0cc372f0-dirty

Given the above test results, it seems very likely to me that the breaking change was introduced somewhere between Iris 1.2.0-pre and Iris 1.2.1-rc1-90bdb008.

I am not sure why Minecraft 1.16.5 is unaffected by this issue ー perhaps that may help clue you guys in on where the issue is occurring.

This issue goes away when water reflections (configuration key waterRefl, or simply comment out #define waterRefl in shaders.settings) is disabled.

Screenshots

Expected behaviour from Minecraft 1.19 + OptiFine+OptiFabric 1.19 HD U H8:
2022-07-23_03 13 42

Incorrect behaviour from Minecraft 1.19 + Iris 1.2.5:
2022-07-23_03 16 30

Another example of incorrect behaviour from Minecraft 1.19 + Iris 1.2.5:
2022-07-23_03 17 03

Operating System

Windows 10 19044.1826 21H2 and macOS 12.4 21F79

What is your GPU?

NVIDIA RTX 2060 (NVGRD 512.95, DCH) and Apple G13J

commented

Potentially related commit in the bisect range: 3d2a4c3

commented

Should be fixed in 45dc976

commented

I just built a local copy of 45dc976 and I can confirm that it does indeed fix this issue on 1.17.1!

commented

Nice!

commented

Closing this issue as 1.2.6 is now public stable, and the issue is resolved now.