Worse performance on Iris 1.2.7+ vs pre 1.2.6 Iris when looking away from the sun.
PlanetSun3 opened this issue · 9 comments
What happened?
- Go into any world
- /gamerule DoDaylightCycle false
- /time set 0
- Look away from the sun or do /tp @s 0 128 0 90 0 (but make sure you load in all the chunks before you look away from the sun)
Repeat steps 1-4 with Iris 1.2.6. Notice how the fps is considerably higher with 1.2.6 than 1.2.8. I also noticed that the amount of shadow terrain jumped from 2400 to 4400, which I am absolute certain is causing this loss in framerate. Same mods used for both versions, apart from updated indium and sodium extra versions so they could work with 0.4.3+
Screenshots
Log output
Minecraft Version
1.19.2
Iris Version
1.2.6 and 1.2.8 (same bug with 1.2.8 also exists in 1.2.7)
Operating System
Windows 10
What is your GPU?
GTX 1080
Additional context
No response
We've found the cause of this to be a seemingly rogue check in the Frustum calculation that incorrectly marks intersecting chunks as inside. For now, we've disabled the check, fixing the chunk count at a slight performance cost.
Just retested using 1.4.1 and I'm still getting double chunk count on the shadows, same position as before. It might have decreased by a few hundred but nowhere near the 2500 or so on 1.2.6 and before.
Yep; “1.4.1’ ended up being a hotfix update to 1.4.0 that didn’t include the final fix.
Well, even with 1.4.2 I'm still getting 2x chunk count. I think somehow the commit that fixed it still hasn't made it onto the branch that 1.4.2 is based on, since I manually compiled "1.19.1" and the chunk count was fine.