Iris Shaders

Iris Shaders

36M Downloads

block.properties is not preprocessed with the values of config options

rhjdvsgsgks opened this issue ยท 2 comments

commented

What happened?

unable load shader if something like

block.xx = some_block \
             #ifdef SOME_OPTION
                 some_extra_block \
             #endif
             another_block

in the block.properties

Screenshots

No response

Log output

Non [a-z0-9/._-] character in path of location: minecraft:#ifdef

Minecraft Version

1.18.2

Iris Version

iris-mc1.18.2-1.4.0-ce18337c

Operating System

linux

What is your GPU?

intel igpu

Additional context

#1033 (comment)

commented

issue with that is that #ifdef and #endif lines get replaced with blank lines by the preprocessor, which breaks the \ line concatenation
so the example gets converted to

block.xx = some_block \

some_extra_block \

another_block

instead of

block.xx = some_block \
some_extra_block \
another_block
commented

okay, didn't read the issue correctly, the initial issue should already be fixed, but that fix causes my mentioned issue now