Iris Shaders

Iris Shaders

36M Downloads

Tons of DH chunks lost in shadow when render distance greater than shadow distance

GeForceLegend opened this issue ยท 3 comments

commented

What happened?

When setting render distance from 7 to 8 chunks, about 95% DH chunks disappeared in shadowmapping, when world time is set to 23500 (not sure if this also exist on other time) and shadowDistance is 120, even most of them are not expected to disappear

Screenshots

Render distance set to 7, about 440 DH chunks are rendered in shadowmapping
20240714-144815
20240714-145507
Render distance set to 8, only 25 DH chunks are rendered in shadowmapping
20240714-144840
20240714-145522

Log output

No response

Minecraft Version

1.20.6

Iris Version

iris-1.7.1+mc1.20.6.jar, DistantHorizons-2.1.2-a-1.20.6.jar

Operating System

Windows10 Home 22H2 19045.4529

What is your GPU?

NVIDIA GeForce RTX 4070

Additional context

No response

commented

After further testing, this seems to happen when render distance >= shadow distance, for example, when shadow distance is set to 240, if render distance is greater or equal than 15 (15 * 16 = 240), then this will happen

commented

Also may affected by shadow.culling. All shader with this issue can get fixed with shadow.culling set to reserved or true (tho certain shader pack may not suit this). And some shader pack that does not have this issue can make it happen if deleting shadow.culling or set it to false.

Bliss is special, for unknown reason, DH shadow always works fine, no matter if shadow.culling exists or set to those values. Haven't figure out why Bliss is special yet. Manually set shadow.culling = false will make this issue happen on Bliss too.

commented

causing code is here

if (distance <= 0 || distance > Minecraft.getInstance().options.getEffectiveRenderDistance() * 16) {

this doesn't check for dh, and uses a box culler, instead of no culling when shadow distance is lower than render distance

edit:
although that isn't fully correct either. it should still do the box culler for regular terrain, but h no culling for DH