wrong blocks waving with multiconnect on 1.8-1.12.2 servers
Mithos23 opened this issue · 7 comments
What happened?
When switching to complementary while connected to a 1.8-1.12.2 server using multiconnect 1.4.8, grass blocks will start waving instead of grass.
Screenshots
Video capturing the issue by Finoway on discord: https://www.youtube.com/watch?v=OPKkRD5gjLQ
Relevant log output
No response
Iris and Minecraft Version
iris-mc1.17-1.1.0
Are you running Sodium along with Iris?
No
Operating System
Windows 10
What is your GPU?
AMD Radeon r9 380x
Java Version
Java 16
Additional context
No response
Hello, thanks for doing it for me because I don't know why github didn't want me to do the issue, and here is where I encountered the problem.
For me:
Screenshots
Minecraft 1.17.1:
Minecraft 1.17.1 with multiconnect on 1.13:
Minecraft 1.17.1 with multiconnect on 1.12.2:
Minecraft 1.17.1 with multiconnect on 1.8.x:
Relevant log output
Iris and Minecraft Version
iris-mc1.17-1.1.0+rev.01d8631.jar for minecraft 1.17.1
multiconnect 1.4.6 because I was not up to date on the video but now I have tested with multiconnect 1.4.8 and still the same problem
Are you running Sodium along with Iris?
I tried with / without sodium (0.3.0-IRIS1-rev.faa155f), lithium, starlight, sodium-extra, hydrogen, falling leaves and EntityCulling.
Operating System
Operating System: Arch Linux
KDE Plasma Version: 5.22.3
KDE Frameworks Version: 5.84.0
Qt Version: 5.15.2
Kernel Version: 5.10.50-1-lts (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 4600H with Radeon Graphics @ 3.000GHz
Memory: 15.1 Gio of RAM
Graphics Processor: AMD Renoir (processor) and AMD Radeon RX 5500M(dedicated)
What is your GPU on minecraft ?
AMD Radeon RX 5500M
Java Version
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment (build 16.0.1+9)
OpenJDK 64-Bit Server VM (build 16.0.1+9, mixed mode)
Additional context
To use it without problem load the shader on a multiconnect version of minecraft than 1.13 or on the main menu.
Example: https://youtu.be/OPKkRD5gjLQ
The cause of this is from multiconnect, but iris might be able to do something about it
Additionally, this seems to be because of weird translation code in multiconnect, and only happens if shaders are not applied before joining the server, or are reloaded on the server
This seems more like an issue of Multiconnect replacing the content of vanilla registries with the pre-flattening entries, meaning that shaders referencing the one-block tall grass foliage using its 1.13+ name (minecraft:grass) end up referencing grass blocks (which have the name minecraft:grass in pre-flattening versions of Minecraft).
As such, the issue on Multiconnect is probably more applicable: Earthcomputer/multiconnect#205
While it would be possible for Iris to fix this, if Multiconnect did not revert block IDs to their pre-flattening values obviously that would be preferable.
@coderbot16 the 1.19 version of multiconnect has fixed this issue.