Sodium for 1.17 disables sky rendering when underwater and when blind, breaking some shader packs

Question

Sodium for 1.17 disables sky rendering when underwater and when blind, breaking some shader packs

coderbot16 opened this issue 3 years ago · 7 comments

coderbot16 commented 3 years ago

This was caused by CaffeineMC/sodium-fabric#710

I think disabling the "sunset" part when underwater should fix most of the weird visual issues without breaking packs.

IMS212 · Answer 1 · 2021-07-28T02:46:28.000Z

Sounds good, I’ll change it.

sylv256 · Answer 2 · 2021-07-28T02:46:33.000Z

That would work for now, and I can investigate disabling the sunset effect while underwater / blind later.

You may also want to disable clouds while underwater too.

IMS212 · Answer 3 · 2021-07-28T02:44:24.000Z

Would disabling the PR if a shaderpack is loaded be an adequate fix?

sylv256 · Answer 4 · 2021-07-28T02:45:04.000Z

I am able to reproduce this bug with my test shaderpack. https://github.com/CursedMC/sodium-iris-fog-test

Note: The blindness status effect is currently broken in the shaderpack. As far as I'm aware, it isn't an iris bug.

coderbot16 · Answer 5 · 2021-07-28T02:45:51.000Z

That would work for now, and I can investigate disabling the sunset effect while underwater / blind later.

sylv256 · Answer 6 · 2021-07-28T18:40:19.000Z

I've tested the test shader against the latest sodium + iris builds and it appears to be fixed.

coderbot16 · Answer 7 · 2021-07-28T18:50:43.000Z

Fixed in IrisShaders/sodium-fabric@f42a255

Share to