Oak stairs are emissive when using SEUS PTGI HRR
Draconizations opened this issue · 7 comments
What happened?
Oak stairs are emissive when using SEUD PTGI HRR shaders. I checked most of the other shaders I have installed (complementary, BSL, sildur's vibrant) and they do not appear to have the same issue. Neither do any of the other stairs.
Screenshots
Relevant log output
No response
Iris and Minecraft Version
iris-and-sodium-mc1.17-1.1.2+build.9.jar for minecraft 1.17.1
Are you running Sodium along with Iris?
Yes
Operating System
Windows 10
What is your GPU?
Nvidia GeForce GTX 1650 Ti
Java Version
Java 16.0.1
Additional context
I have Indium and other mods installed, let me know if this changes things and I'll check just sodium+iris as well.
This is caused by Iris not properly handling #elif directives when parsing block.properties.
As a result, the 1.13 block ID mappings for SEUS PTGI HRR override the 1.14+ block ID mappings. In this case, Sonic Ether forgot to update the 1.13 mappings when he added support for the new 1.16 blocks, meaning that Oak Stairs are getting mapped to minecraft:soul_fire, causing them to emit blue light.
It seems like if you loaded up SEUS PTGI HRR on OptiFine for 1.13, you'd observe similar issues, interestingly enough.
This is caused by Iris not properly handling
#elifdirectives when parsingblock.properties.As a result, the 1.13 block ID mappings for SEUS PTGI HRR override the 1.14+ block ID mappings. In this case, Sonic Ether forgot to update the 1.13 mappings when he added support for the new 1.16 blocks, meaning that Oak Stairs are getting mapped to
minecraft:soul_fire, causing them to emit blue light.It seems like if you loaded up SEUS PTGI HRR on OptiFine for 1.13, you'd observe similar issues, interestingly enough.
so deleting the entire #elif argument fixes the problem for now?
Well, you'd need to manually delete everything between the #elif and the #else block, since the #elif isn't the issue, it's everything after it and before the #else that isn't getting properly ignored.