Iron Backpacks

Iron Backpacks

Mods
54M Downloads

Removing a nesting upgrade does not remove already nested backpacks

Hazerd opened this issue ยท 1 comments

commented

Issue Description:

If you have backpacks nested within another via the Nesting upgrade (or Advanced version) and remove the upgrade, any backpacks already inside the primary backpack will remain.

This could allow one to fill a backpack with other backpacks, then remove the Nesting Upgrade to use the points for other upgrades.

What happens:

The backpack keeps the other backpacks currently nested inside of it. If the nested backpacks are manually removed they cannot be re-inserted.

What you expected to happen:

Either:

  • Nested backpacks should be removed automatically when the Nesting Upgrade is removed.
  • The Nesting Upgrade should not be removable when the backpack contains other backpacks.

Steps to reproduce (important):

  1. Create two new backpacks (thus named "Nesting" and "Nested")
  2. Attach a Nesting Upgrade or Advanced Nesting Upgrade into the "Nesting" backpack.
  3. Insert the "Nested" backpack into the "Nesting" backpack.
  4. Remove the Nesting Upgrade from the "Nesting" backpack.
  5. Open the "Nesting" backpack and notice the "Nested" backpack is still inside.

Affected Versions (Do not use "latest"):

  • IronBackpacks: 1.10.2-2.2.5
  • Minecraft: 1.10.2
  • Forge: 12.18.2.2099, 12.18.2.2107, presumably others.
commented

Good catch, I didn't think of this exploit.