Iron Chests

Iron Chests

Mods
171M Downloads

[1.8] Few issues

61352151511 opened this issue ยท 0 comments

commented

I've been trying to look into the issues myself but can't seem to find the problem.

  1. When you upgrade any chest the chest loses it's contents. I'm not sure where this happens in the code, while trying to test I put multiple debug statements to print the contents of newchest in ItemChestChanger.onItemUseFirst:43 all print the correct contents. Even after world.setTileEntity(pos, newchest); on line 91 getting the tile entity again and printing the chest contents seems to print the correct contents however they are not in the chest when opening. It may be a syncing issue.
    Edit: Fixed with #38

  2. When a player on a server is placing an iron chest of any type, or upgrading an existing chest using ItemChestChanger, all other players (If the chunks are loaded for them? Haven't tested from far away) get "A fatal error has occured, this connection has terminated" Again syncing issue?

Edit: I've crashed myself when placing an iron chest a few times while others are fine, so not sure what the cause of this is.

  1. This isn't really an issue but there are unused imports in RegistryHelper.java
    java.util.Map
    net.minecraft.item.Item
    net.minecraftforge.fml.common.ObfuscationReflectionHelper
    Edit: Fixed with #38

  2. Upgrading chests doesn't keep the chests rotation as well as chests rotations always reset to a fixed direction upon rejoining

  3. This http://pastebin.com/NVdt5xr6

  4. Missing texture particles when breaking iron chests