Iron Jetpacks

Iron Jetpacks

50M Downloads

All thrusters have the same item ID regardless of material; same for energy cells, etc

CthonicSyzygies opened this issue ยท 7 comments

commented

Describe the bug
Every thruster shares an item id with all other thrusters, of the format "ironjetpacks:thruster" without any specified material. The same is true for energy cells (ironjetpacks:cell) and capacitors (ironjetpacks:capacitor).

Presumably as a result: when any player logs into our server, they receive a rapid-fire set of recipe advancement notifications which appears to be for every Iron Jetpacks item. On the server, the console spits out information that the recipes could not be loaded (attached)

To Reproduce
Have Iron Jetpacks installed, as far as I can tell.

Expected behavior
Thrusters of different materials should have separate item ids unique to the material, more akin to ironjetpacks:electrum_thruster and ironjetpacks:diamond_thruster

Screenshots / Scripts / Logs
image
image
(this repeats for each material thruster, as well as energy cells with energy cells, etc)
iron jetpacks unrecognized recipes.txt
Our modlist likely is not relevant but I have included it just to be sure.
modlist.txt

Versions (please complete the following information):

  • Minecraft: 1.18.1
  • Forge: 39.0.19
  • Cucumber: Cucumber-1.18.1-5.0.2
  • Iron Jetpacks: IronJetpacks-1.18.1-5.0.2
commented

Can you provide the full log? There might have been an issue that occurred earlier.

commented

I apologize for the delay, I wasn't sure what log you meant so I kept putting it off. I hav
e just generated a new pack in 1.18.1 with only Iron Jetpacks and JEI (as well as Cucumber), launched it, and verified that with only these parameters, the problem persists. "ironjetpacks:thruster" rather than "ironjetpacks:diamond_thruster" vs "ironjetpacks:iron_thruster".

here is the log from the world i created and opened with these parameters.
Jetpacks Log.txt

commented

i'm looking at this too in (IronJetpacks-1.18.2-5.1.2) while doing some custom recipe work in atm7 (0.4.18) for our late game stuff, and i've noticed that all of the components are tagged as above, but are correct when you look at their NBT data, it'll give Id: ironjetpacks:<material> with the material being whatever it is made of, eg diamond, or gold.

This might also be the cause of a bug i've noticed and thought was reported, where you could make any teir of jetpack with any other jetpack as a base model.
Example 1, a stone jetpack made from a silver one
2022-07-03_22 20 08
Example 2, a Emerald Jetpack made from a wooden one
2022-07-03_22 22 54

commented

@Mitchell5200 that is (I believe) a separate issue which will be fixed in the next release.

commented

@Mitchell5200 that is (I believe) a separate issue which will be fixed in the next release.

Excellent to know

commented

Is this issue still occurring on the latest version?

commented

im using

  • Minecraft - 1.18.2
  • Forge - 40.1.86
  • Cucumber - 1.18.2-5.0.7.1
  • Iron Jetpacks - 1.18.2-5.1.4

and this is still a issue if im reading correct
image
image
image
image