Iron Chests: Restocked

Iron Chests: Restocked

9M Downloads

Chest upgrades do not respect upgrade_types configs

Sythiex opened this issue · 0 comments

commented

The chest upgrade items do not appear to be following the rules set in "\config\ironchests\upgrade_types". Any chest from this mod can be "upgraded" with ANY chest upgrade item (including one of the same tier, i.e. copper → copper). For example, a copper chest can be upgraded directly to a netherite chest with a netherite chest upgrade despite the default configs suggesting that only a diamond chest should be upgradable with a netherite chest upgrade. Higher tier chests can also be downgraded this way but delete any items in the extra slots that no longer fit in the smaller chest, and throw this error:

show
java.lang.ArrayIndexOutOfBoundsException: Index 36 out of bounds for length 36
	at java.base/java.util.Arrays$ArrayList.set(Arrays.java:4170)
	at TRANSFORMER/[email protected]/net.minecraft.core.NonNullList.set(NonNullList.java:54)
	at TRANSFORMER/[email protected]/tech.thatgravyboat.ironchests.common.blocks.GenericChestBlockEntity.setItems(GenericChestBlockEntity.java:152)
	at TRANSFORMER/[email protected]/tech.thatgravyboat.ironchests.common.items.UpgradeItem.changeToChest(UpgradeItem.java:108)
	at TRANSFORMER/[email protected]/tech.thatgravyboat.ironchests.common.items.UpgradeItem.m_6225_(UpgradeItem.java:48)
	at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:628)
	at TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.m_41661_(ItemStack.java:222)
	at TRANSFORMER/[email protected]/net.minecraft.server.level.ServerPlayerGameMode.m_7179_(ServerPlayerGameMode.java:354)
	at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.m_6371_(ServerGamePacketListenerImpl.java:985)
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m_5797_(ServerboundUseItemOnPacket.java:30)
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.m_5797_(ServerboundUseItemOnPacket.java:8)
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:22)
	at TRANSFORMER/[email protected]/net.minecraft.server.TickTask.run(TickTask.java:18)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:157)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:799)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:164)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:131)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_129961_(MinecraftServer.java:782)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_7245_(MinecraftServer.java:776)
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_18701_(BlockableEventLoop.java:140)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_130012_(MinecraftServer.java:762)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:689)
	at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261)
	at java.base/java.lang.Thread.run(Thread.java:833)

Versions:
Minecraft: 1.18.2
Forge: 40.2.0
Iron Chests: Restocked: ironchests-2.0.4-forge