Iron's Gems 'n Jewelry

Iron's Gems 'n Jewelry

3M Downloads

[Bug] Improper equals implementation

uhloin opened this issue ยท 3 comments

commented

Observed behaviour

Rings probably does not implement properly hashCode and equals, as result, it cannot be extracted from Integrated Dynamics storage.
Pair issue:
CyclopsMC/IntegratedDynamics#1466
Similar issue with Silent Gear mod:
CyclopsMC/IntegratedTerminals#130
Docs:
https://docs.neoforged.net/docs/items/datacomponents/#creating-custom-data-components

Expected behaviour

Stored ring must be extracted

Steps to reproduce

  1. Install ID mods
  2. Create Jewelcraft Station and set it somewhere
  3. Use 4 gold ingots in the station to create some ring
  4. Create a simple ID network (chest, terminal)
  5. Put the ring to network, try get it back

Server Type

Single Player

Crashlog

No response

Mod version

1.21.1-1.0.6

Forge version

NeoForge 1.21.1 - 21.1.95

Other mods

commoncapabilities-1.21.1-neoforge-2.9.7-195.jar
cyclopscore-1.21.1-neoforge-1.25.6-710.jar
integrateddynamics-1.21.1-neoforge-1.25.3-1070.jar
integratedtunnels-1.21.1-neoforge-1.8.33-368.jar
integratedterminals-1.21.1-neoforge-1.6.7-456.jar
integratedcrafting-1.21.1-neoforge-1.1.13-269.jar

Crashlog Check

  • I understand if this is a crashbug and I did not attach a crashlog, this will not be handled
commented

(also specifically see this comment in above linked issue)

commented

implementation fixed in 1.0.7. should fix conflict

commented

Yes, it's fixed, thank you for fast reaction!