Iron's Gems 'n Jewelry

Iron's Gems 'n Jewelry

3M Downloads

[Crash] For some reason, village offer can sometimes be empty and crashes server

pietro-lopes opened this issue ยท 1 comments

commented

Observed behaviour

I don't know how to reproduce, but got this from server owner that had a player trying to pickup or catch a jewelry villager (leveled up, don't know which level)

Expected behaviour

Maybe check before creating MerchantOffer if the itemstack parameter is empty
https://github.com/iron431/irons-jewelry/blob/1.21.1/src/main/java/io/redspace/ironsjewelry/core/Trades.java

Steps to reproduce

๐Ÿ’€

Server Type

Dedicated Server

Crashlog

https://gnomebot.dev/paste/mclogs/x9V99mu#L10013

Mod version

1.21.1-1.0.7

Forge version

Neo 21.1.116

Other mods

ATM10 Modpack

Crashlog Check

  • I understand if this is a crashbug and I did not attach a crashlog, this will not be handled
commented

fixed in 1.0.8